This repository was archived by the owner on Jun 8, 2026. It is now read-only.
Feature/edit company details - #308
Merged
Merged
Conversation
|
Your Render PR Server URL is https://nijobs-backend-pr-308.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cflt59p4reb319msmn8g. |
Author
|
Please review the tests to see if they are good and complete or if I need to add more test cases. |
BrunoRosendo
suggested changes
Feb 16, 2023
BrunoRosendo
left a comment
BrunoRosendo
left a comment
Contributor
There was a problem hiding this comment.
Good job so far! I left some suggestions
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #308 +/- ##
===========================================
- Coverage 90.33% 90.13% -0.20%
===========================================
Files 54 54
Lines 1417 1440 +23
Branches 232 232
===========================================
+ Hits 1280 1298 +18
- Misses 132 137 +5
Partials 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
BrunoRosendo
suggested changes
Feb 28, 2023
BrunoRosendo
left a comment
BrunoRosendo
left a comment
Contributor
There was a problem hiding this comment.
Looks good, I left some suggestions. It'd probably be nice to get the company from db/service after editing and checking if everything is ok, at least in one test
Naapperas
suggested changes
Feb 28, 2023
Closed
marco-vb
force-pushed
the
feature/edit-company-details
branch
2 times, most recently
from
February 28, 2023 16:26
16629f3 to
e694e77
Compare
marco-vb
requested review from
FranciscoCardoso913,
Naapperas,
Process-ing and
dsantosferreira
February 28, 2023 16:30
Naapperas
suggested changes
Mar 1, 2023
added 13 commits
March 7, 2023 14:25
…MPANY_EDIT_NOTIFICATION to the templates
…(were not being used)
added 14 commits
March 7, 2023 14:25
… for blocked and disabled companies
… before starting the actual tests, as suggested
marco-vb
force-pushed
the
feature/edit-company-details
branch
from
March 7, 2023 15:47
e694e77 to
309de07
Compare
BrunoRosendo
previously approved these changes
Mar 7, 2023
BrunoRosendo
left a comment
BrunoRosendo
left a comment
Contributor
There was a problem hiding this comment.
lgtm, maybe @Naapperas wants to re-review
Naapperas
suggested changes
Mar 9, 2023
added 4 commits
March 9, 2023 19:39
Naapperas
approved these changes
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.