Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

Refactor tests - #311

Open
Naapperas wants to merge 30 commits into
developfrom
fix/fix-tests
Open

Naapperas wants to merge 30 commits into
developfrom
fix/fix-tests

Conversation

@Naapperas

@Naapperas Naapperas commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator

Closes #169

This attempts to fix and "normalize" the many tests we have on NIJobs in order to make them more manageable.

@render

render Bot commented Mar 1, 2023

Copy link
Copy Markdown

@Naapperas Naapperas changed the title Refactored auth tests Refactor tests Mar 1, 2023
@codecov-commenter

codecov-commenter commented Mar 1, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f698ee0) 90.33% compared to head (f23a0e1) 90.45%.
Report is 1 commits behind head on develop.

❗ Current head f23a0e1 differs from pull request most recent head 5bd79a6. Consider uploading reports for the commit 5bd79a6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #311      +/-   ##
===========================================
+ Coverage    90.33%   90.45%   +0.12%     
===========================================
  Files           54       54              
  Lines         1469     1477       +8     
  Branches       245      245              
===========================================
+ Hits          1327     1336       +9     
+ Misses         137      136       -1     
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Naapperas
Naapperas force-pushed the fix/fix-tests branch 2 times, most recently from 65c93ea to c2a11e5 Compare March 28, 2023 16:46
@Naapperas

Copy link
Copy Markdown
Collaborator Author

After refactoring work on this PR is finished, I am going to write documentation regarding how contributors should write tests.

@Naapperas
Naapperas force-pushed the fix/fix-tests branch 2 times, most recently from 290bc05 to 08a3ecc Compare April 25, 2023 21:44
@Naapperas Naapperas self-assigned this Apr 27, 2023
@Naapperas

Copy link
Copy Markdown
Collaborator Author

Looks like we will still need to wait for a new version of fast-xml-parser

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Normalize" tests

2 participants