Show hidden offers to admin

[diogofonte]

Closes #236

[Naapperas]

@CarlosMealha @diogofonte any updates on this?

[diogofonte]

@CarlosMealha @diogofonte any updates on this?

We were waiting for opinions about the divs that are causing extra space in mobile view search, but the button "show hidden offers" is ready.
This is not the not the principal objective of this PR, but the problem affects directly our issue.

[CarlosMealha]

@CarlosMealha @diogofonte any updates on this?

Also, is there any endpoint responsible to fetch hidden offers or we need to filter the offers in order to specify them ?

[Naapperas]

@CarlosMealha @diogofonte any updates on this?

Also, is there any endpoint responsible to fetch hidden offers or we need to filter the offers in order to specify them ?

the GET /offers endpoint already handles this: you need to pass a query value named showHidden, if I recall correctly, and set it to true in order to see hidden offers (if you have permission to do so of course).

If you are asking in the context of this PR, the feature that needs to be implemented is the possibility for admins to pass that showHidden value, which is currently not possible. Maybe I misunderstood your question.

[Naapperas]

@CarlosMealha @diogofonte any updates on this?

We were waiting for opinions about the divs that are causing extra space in mobile view search, but the button "show hidden offers" is ready. This is not the not the principal objective of this PR, but the problem affects directly our issue.

I think I looked around a while ago and recall this being an issue in the MultiOptionAutocomplete component, not that one, but i might be wrong. If the problem is in the component you showed maybe you could replace the React Fragment (the <></> thing) with null and see if it works.

[CarlosMealha]

@CarlosMealha @diogofonte any updates on this?

Also, is there any endpoint responsible to fetch hidden offers or we need to filter the offers in order to specify them ?

the GET /offers endpoint already handles this: you need to pass a query value named showHidden, if I recall correctly, and set it to true in order to see hidden offers (if you have permission to do so of course).

If you are asking in the context of this PR, the feature that needs to be implemented is the possibility for admins to pass that showHidden value, which is currently not possible. Maybe I misunderstood your question.

Yes, my question was about the endpoint specifically, and your answer cleared my doubts. Thank you!

[CarlosMealha]

Okay, me and Diogo made the show hidden toggle on admin account working properly

[Naapperas]

Since there is no backend to test this (at the moment), please include a small video demonstrating this feature.

[Naapperas]

There should be tests regarding the UI and Request making parts of this feature, not just the Redux store one.

[Naapperas]

Also, beware of the upstream changes, you'll need to rebase this branch with develop later.

[codecov-commenter]

Codecov Report

Patch coverage: 70.37% and project coverage change: -0.21 ⚠️

Comparison is base (e2c6463) 89.05% compared to head (5626b67) 88.84%.

❗ Current head 5626b67 differs from pull request most recent head 1d046e2. Consider uploading reports for the commit 1d046e2 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #291      +/-   ##
===========================================
- Coverage    89.05%   88.84%   -0.21%     
===========================================
  Files          176      175       -1     
  Lines         3390     3345      -45     
  Branches       851      845       -6     
===========================================
- Hits          3019     2972      -47     
- Misses         371      373       +2     

Impacted Files	Coverage Δ
...ltsArea/SearchResultsWidget/SearchResultsMobile.js	80.00% <ø> (ø)
...mponents/HomePage/SearchArea/useUrlSearchParams.js	89.79% <16.66%> (-8.45%)	⬇️
...SearchArea/AdvancedSearch/AdvancedSearchDesktop.js	91.66% <75.00%> (-8.34%)	⬇️
.../SearchArea/AdvancedSearch/AdvancedSearchMobile.js	77.41% <75.00%> (-0.36%)	⬇️
...age/SearchArea/AdvancedSearch/useAdvancedSearch.js	96.77% <83.33%> (-3.23%)	⬇️
src/actions/searchOffersActions.js	100.00% <100.00%> (ø)
src/components/HomePage/SearchArea/SearchArea.js	100.00% <100.00%> (+2.12%)	⬆️
src/reducers/searchOffersReducer.js	100.00% <100.00%> (+3.63%)	⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[CarlosMealha]

Codecov Report

Base: 88.98% // Head: 88.96% // Decreases project coverage by -0.03% warning

Coverage data is based on head (6e15449) compared to base (5f96cb4).
Patch coverage: 85.71% of modified lines in pull request are covered.

mega This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files

umbrella View full report at Codecov. loudspeaker Do you have feedback about the report comment? Let us know in this issue.

We will take care of this as the feature for the related showHidden URL filter are still in progress and the corresponding tests

[diogofonte]

Now the showHidden attribute is present in the URL

Video demonstrating the final result:

show_hidden_offers.mp4

[BrunoRosendo]

I'll leave the code review for the others but I think the result looks neat!

[tomaspalma]

Everything looks good and is working.

There is just a small detail that in terms of functionality doesn't really matter probably, but basically, if a user without privileges types showHidden=false or true, it shows a dot on the settings icon near the search bar, but then when we click it, in the advanced filters menu, there is obviously nothing there.

However, I believe this doesn't do anything because as far as I saw, the backend checks if a user has privileges or not to show the hidden offer and his an edge case that would probably never happen, so it's not that important.

[Naapperas]

Left a small comment.

@DoStini please review this code once more, since Github is picky about change requests 🙃

[Naapperas]

I'm not a big fan of this: this class should have another name, and not one that simply re-states what it does style-wise.

[Naapperas]

Also, don't forget to rebase.