This repository was archived by the owner on Jun 8, 2026. It is now read-only.
Add Suspense to Router and Lazy loading of page components - #42
Draft
imnotteixeira wants to merge 1 commit into
Draft
imnotteixeira wants to merge 1 commit into
imnotteixeira wants to merge 1 commit into
Conversation
imnotteixeira
force-pushed
the
fix/router-lazy-load
branch
from
November 18, 2019 19:37
e9edd3f to
cdb1126
Compare
Collaborator
Author
|
I would like to highlight that the Suspense API (required to use |
imnotteixeira
marked this pull request as draft
April 14, 2020 13:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change takes advantage of the recent React.lazy and React.Suspense APIs which allow us to load our components more selectively, relieving the end user from loading components he is not even looking at.
Extra: Added progress bars between page changes, it looks so good.