Fix hash type mismatch in vignettes and Roxygen docs#212
Merged
Conversation
Merged
Co-authored-by: kyle-messier <127860447+kyle-messier@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback from review on the 'Migrate' pull request
Fix hash type mismatch in vignettes and Roxygen docs
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
download_hash()computes a combined MD5 hash via themd5sumsystem binary, but vignettes and several Roxygen@param/@returndocs described it as SHA-1 or referenced the now-unusedrlang::hash_file().Changes
gridmet_workflow,terraclimate_workflow,narr_workflow,epa_download,modis_workflow): Updated 7hash = TRUEbullet descriptions from "SHA-1 hash" → "MD5 hash"R/download.R: Replaced 11 occurrences of\code{rlang::hash_file()}/\code{rlang::hash_file}in@param hashand@returnentries with "a combined MD5 hash string", matching the actualdownload_hash()implementation✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.