Repository navigation
fix(bitcoin-blake2b): support Knots 29.4.2 maturity and RPC - #207
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 4, 2026
fix(bitcoin-blake2b): support Knots 29.4.2 maturity/RPC changes and refresh DATUM compatibility
#205
Open
NINJAK1DD
force-pushed
the
feat/knots-29-4-2-maturity
branch
from
October 4, 2026 16:53
e5f16ea to
b656089
Compare
…tibility Move BLAKE2b reward classification into a dedicated payout handler, leaving shared Bitcoin/Nexa/AuxPoW classification behavior unchanged. Use retained block headers so body pruning cannot strand long-locked coinbase rewards. Match wallet/header identities and depth, preserve owned immature credit, quarantine unsupported direct rows and bound redacted reconciliation alerts. Bind each pool's verified chain/maturity schedule for the process lifetime. Allow reviewed bounded user-agent customization, isolate expected-work RPC models, align regtest overrides with released Knots source, and refresh the catalogue pin and upgrade/successor-review guidance. Cache and re-hash pinned upstream source; retain failed functional-test logs. Add real pruning/maturity/reorg fixtures, payout/PoS compatibility checks, production DI coverage and offline cache/failure diagnostics. Validated in the documented lab: 3604 Linux tests passed with one skipped benchmark; 623 Windows compatibility/live/ledger tests and 76 diagnostic tests passed. Both upstream functional tests passed with cold/warm caches. References #205 and PR #207. DATUM end-to-end acceptance remains in #163.
…ayout stalls Revisit custodial orphan rows in rotating keyset batches of 64 within 12960 blocks of the observed tip. Require matching active header/wallet evidence and unchanged candidate identities under the row lock before reopening a row. Keep unavailable orphans unresolved and exclude confirmed custodial rows so stale classification cannot allocate the same reward twice or reverse PPS. Add fixed redacted payout-attestation reasons and bounded alerts for outages, syncing, contract drift and process-binding changes. Preserve cancellation semantics, restore wallet-category success logging and withhold received subversion payloads from startup errors and diagnostics. Document pre-upgrade payout drain, re-locked prior coinbases/payout change, post-upgrade wallet/liability reconciliation and safe missing-header repair. Move unused expected-work response models into source-contract test fixtures and describe the production behavior accurately. Verify persisted Pending -> Orphaned -> Pending/Confirmed through real Knots, PostgreSQL, PayoutManager, repositories and all four payout schemes without manually resetting status. Cover restart, immutable evidence changes, bounded rotation, redacted reason episodes, cancellation and stale replay refusal. Validation: 3635 Linux tests passed, zero failures, one skipped benchmark; 730 Windows live/ledger/compatibility/diagnostic tests passed with no skips. Five maturity integration tests and 254 focused tests also passed independently. Documentation, workflow pins, diagnostic sources, offline cache and shell gates passed. References #205 and PR #207; DATUM acceptance remains in #163.
NINJAK1DD
force-pushed
the
feat/knots-29-4-2-maturity
branch
2 times, most recently
from
October 4, 2026 22:35
9d05c71 to
b7547a7
Compare
NINJAK1DD
force-pushed
the
feat/knots-29-4-2-maturity
branch
from
October 4, 2026 22:58
b7547a7 to
c2f220a
Compare
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knots 29.4.2 removes
getdifficultyand requires 6481 wallet confirmations for every coinbase, independently of its temporary consensus interval. This change validates the supported BLAKE2b build/chain/maturity contract and reconciles rewards while preserving ledger identities and legacy Bitcoin-family behavior.scripts/ops/; it cannot alter balances, payments or block state.Compatibility guide and validation evidence, daemon error audit, and audited quarantine closure describe the implementation and operator boundaries.
Validation: production source
8616eb0cpassed 899 selected Windows and 3742 full Linux lab tests with zero failures and one Linux benchmark skip. The RPC/collection selection at48ab5fcbpassed 164 Windows and 164 Linux tests with zero failures/skips. The full CI lane for48ab5fcbpassed 3760 tests, zero failed, one benchmark skip; both Ubuntu release lanes passed 3691 tests, zero failed, 44 skips each. Source builds, PostgreSQL 15–18 schemas, archives, containers and macOS/musl reservation checks succeeded. These counts identify the tested heads. Documentation-only headd1955d7986cf6dd7262fa467d038c03fae30b6d0passed local link/anchor checks for all 40 Markdown files and whitespace checks; its CI is pending.Retain the immediately-before-merge head/CI/Knots release/proposal recheck and #163 DATUM gateway/node/miner/direct-reward acceptance. References #205, #151 and #163.