Skip to content

feat: Add opt-in construction-attribute classification for distribution lines #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m1muralid wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Add opt-in construction-attribute classification for distribution lines #92

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08ef879
Add opt-in construction-attribute classification for MatrixImpedanceB…
m1muralid Sep 1, 2026
f6707f9
Adding context manager for use_construction_attribute flag
m1muralid Sep 1, 2026
64921d8
Merge branch 'main' into mm/update_dist_line_mapping
m1muralid Sep 1, 2026
082becb
Merge branch 'mm/update_dist_line_mapping' of https://github.com/NREL…
m1muralid Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions src/erad/gdm_mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,28 @@
from contextlib import contextmanager

import gdm.distribution.components as gdc
import gdm.distribution.equipment as gde
from gdm.distribution.enums import LineType

from erad.enums import AssetTypes
from erad.models.asset_mapping import ComponentFilterModel

# Feature flag: when True, classify distribution MatrixImpedanceBranch components using
# equipment.construction (LineType) instead of the c_matrix threshold heuristic.
USE_CONSTRUCTION_ATTRIBUTE: bool = False


@contextmanager
def construction_attribute_enabled(enabled: bool = True):
"""Temporarily set USE_CONSTRUCTION_ATTRIBUTE within a `with` block."""
global USE_CONSTRUCTION_ATTRIBUTE
old = USE_CONSTRUCTION_ATTRIBUTE
USE_CONSTRUCTION_ATTRIBUTE = enabled
try:
yield
finally:
USE_CONSTRUCTION_ATTRIBUTE = old

asset_to_gdm_mapping = {
AssetTypes.switch: [
ComponentFilterModel(
Expand Down Expand Up @@ -40,10 +58,11 @@
),
ComponentFilterModel(
component_type=gdc.MatrixImpedanceBranch,
component_filter=lambda x: x.equipment.c_matrix[0, 0]
.to("microfarad/kilometer")
.magnitude
> 0.05
component_filter=lambda x: (
x.equipment.construction == LineType.UNDERGROUND
if USE_CONSTRUCTION_ATTRIBUTE
else x.equipment.c_matrix[0, 0].to("microfarad/kilometer").magnitude > 0.05
)
Comment on lines +61 to +65
and x.buses[0].rated_voltage.to("kilovolt").magnitude < 35.0,
),
],
Expand All @@ -57,10 +76,11 @@
),
ComponentFilterModel(
component_type=gdc.MatrixImpedanceBranch,
component_filter=lambda x: x.equipment.c_matrix[0, 0]
.to("microfarad/kilometer")
.magnitude
< 0.05
component_filter=lambda x: (
x.equipment.construction == LineType.OVERHEAD
if USE_CONSTRUCTION_ATTRIBUTE
else x.equipment.c_matrix[0, 0].to("microfarad/kilometer").magnitude < 0.05
)
and x.buses[0].rated_voltage.to("kilovolt").magnitude < 35.0,
),
],
Expand Down
Loading