Skip to content

Conversation

@hb2708
Copy link
Contributor

@hb2708 hb2708 commented Dec 23, 2025

✅ I have read the contributing file

This fixes the warning coming on open of infomodel #417

Summary

  • As the warning was coming when we open info model the first guess was updating react-native-render-html and it seems to work.

Changelog

  • Updated react-native-render-html package to latest available version (last release in Jan 24, 2022 😅 may need to swap with alternative some day)

Demo

  • No warning logs when opening info model
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2025-12-23.at.22.37.59.mov

@hb2708
Copy link
Contributor Author

hb2708 commented Dec 23, 2025

@PierreBresson

Copy link
Member

@PierreBresson PierreBresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little detail and we are good to merge :)

@PierreBresson
Copy link
Member

Let's find an alternative to react-native-render-html indeed 😄

@hb2708
Copy link
Contributor Author

hb2708 commented Dec 24, 2025

Let's find an alternative to react-native-render-html indeed 😄

New ticket for us to handle that Lets go
Link this in the ticket native-html/render#14

@hb2708 hb2708 requested a review from PierreBresson December 24, 2025 04:14
@hb2708 hb2708 changed the title refactor: Update react-native-render-html to fix warning and adapt HT… refactor: Update react-native-render-html to fix warning and adapt HTML component usage for link styling. Dec 24, 2025
@PierreBresson PierreBresson merged commit c15f0b0 into NMF-earth:main Dec 24, 2025
1 check passed
@PierreBresson
Copy link
Member

@hb2708 Thanks!! 🎄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants