Final adjustments to gen_aig[e]fs_ics.py for production#64
Merged
aerorahul merged 1 commit intoOct 10, 2025
Merged
Conversation
RussellManser-NCO
requested review from
CarlosMDiaz-NCO,
LinlinCui-NOAA,
aerorahul and
junwang-noaa
October 8, 2025 18:20
junwang-noaa
reviewed
Oct 8, 2025
aerorahul
approved these changes
Oct 8, 2025
aerorahul
left a comment
Contributor
There was a problem hiding this comment.
This isn't so bad.
v1.1 will hopefully make the S3 optional and will eliminate the need to comment it out.
Collaborator
@aerorahul Do we know when we need to have v1.1 ready? |
LinlinCui-NOAA
approved these changes
Oct 9, 2025
junwang-noaa
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the last changes that SPA team made to
oper/gen_aigfs_ics.pyoper/gen_aigefs_ics.pyto operationalize the scripts. These changes are a band-aid fix that will need a coordinated fix in the next release. A PR such as #54 would likely resolve these issues. Some key areas we will need to improve on include:
oper/gen_aigefs_ics.pymlgefsprefix, which is consistent with exaigefs_prep.sh