Skip to content

Update/gfsv17 - #132

Open
sbanihash wants to merge 42 commits into
NOAA-EMC:prod/v1.5-gfsv17from
sbanihash:update/gfsv17
Open

sbanihash wants to merge 42 commits into
NOAA-EMC:prod/v1.5-gfsv17from
sbanihash:update/gfsv17

Conversation

@sbanihash

Copy link
Copy Markdown
Collaborator

This PR will bring in prod/v1.5 into gfsv17 downstream code delivery branch.

saeideh banihashemi and others added 30 commits June 8, 2026 05:24
* first step updating grib2 and bull products with NCO naming standards

* updating ripcurrent scripts to account for new grib2 file names

---------

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin02.dogwood.wcoss2.ncep.noaa.gov>
* add set -x to shell scripts

* remove unnecessary set -x in ecf files

* remove additional set -x in ecf files

---------

Co-authored-by: Ming Chen <ming.chen@dlogin06.dogwood.wcoss2.ncep.noaa.gov>
* typo in cray_mpich

* revert lox to use 48 processors

---------

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin05.dogwood.wcoss2.ncep.noaa.gov>
)

* changing contour product names to comply with NCO standards plus removing riphist from COMOUT/NET.PDY/nwges/riphist history contour files will be read directly from the REGION.PDY/DOMAIN/CYCLE/CGnum

* taking out riphist copying from scripts

* addressing reviewer comments, adding .txt extension

---------

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin06.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin01.dogwood.wcoss2.ncep.noaa.gov>
* fix error in nwps_chs_prep

* comment out NEST 2 in GYX domain

* fix missing logicin shiproutes

* avoid creating a directory that already exists

* only copy riphist files if they exist

* make sure GESINm5 is defined

* takes care of issue:
nwps_bro_post_cg1.o267398469:1819051:cat: /lfs/f1/ops/para/tmp/pnwps_bro_para/run/nests.flag: No such file or directory

* updates to make sure we do not conflict with PR 93
which changes the logic structure making these changes un-necessary

* updates for synax issues

* fix cannot stat in wavetrack jobs

---------

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin09.dogwood.wcoss2.ncep.noaa.gov>
…g symbols and traceback support for all compilations (NOAA-EMC#95)

* Resolve compilation warning #266: undeclared function GKfree

* add GKfree function declaration in the header

* Resolve compilation warning #1487: replace deprecated readdir_r

* Fix SelectQueueOneWay typo in headers to resolve warning #266

* replace ifort with ftn for compilation

* enable debug symbols and traceback support for all compilations

---------

Co-authored-by: Ming Chen <ming.chen@dlogin07.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: Ming Chen <ming.chen@dlogin03.dogwood.wcoss2.ncep.noaa.gov>
* syncing with prod

* removing LOUD from scripts

* deleting commented lines

---------

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin07.dogwood.wcoss2.ncep.noaa.gov>
* updates from para  including:

-- export PS4 lines should start with a +
-- updates to ecf & job scripts
-- updates to run.ver
-- typo in errchck

* revert sorc/clean_NWPS.sh
* renaming NWPSdir to HOMEnwps, removing nwges from com path and adding build instructions in sorc

* remove old README file from dev

* Cron update

Updating cron to reflect the change from NWPSdir to HOMEnwps

* updating dev validation scripts to remove NWPSdir and add HOMEnwps

---------

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin07.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin09.dogwood.wcoss2.ncep.noaa.gov>
* bring in fix for gfswind from prod package

---------

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin06.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin09.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin03.dogwood.wcoss2.ncep.noaa.gov>
…NOAA-EMC#104)

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin09.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin04.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin04.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin03.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin09.dogwood.wcoss2.ncep.noaa.gov>
* forecast job had cannot create dir in cgn log

* avoid copying & then attempting to chmod and tar files that do not exist

* update tabs to spaces

* fix if file doesn't exist

* syntax errors for PE directory copies

* only remove files if they exist

* update code with what is in ops
* changing all specpoints to lowercase

* lowercase station for wavetrack script

---------

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin09.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin07.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin04.dogwood.wcoss2.ncep.noaa.gov>
…racters, uppercase characters or the date (NOAA-EMC#110)

* change CG to cg in product names- first attempt

* more lower case CG , Trkng to trkng and SITEID to siteid

* fix the GUM point output to have lowercase letters

* change awipsnwps grib2 files to have lower case for grdID as well

---------

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin04.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin09.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin02.dogwood.wcoss2.ncep.noaa.gov>
* fixing issue with 18z runs in next day for dev runs

* fixing memory issue in dev prep run

---------

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin02.dogwood.wcoss2.ncep.noaa.gov>
…AA-EMC#112)

* fixing bad grib message when the script is waiting for the file to complete

* making more changes to avoid bad grib file message

* change for correct cycle

* hpss account update

---------

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin06.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin01.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin09.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin03.dogwood.wcoss2.ncep.noaa.gov>
mingchen-NOAA and others added 12 commits July 23, 2026 22:39
* enable debug build for swan and punswan

* fix runtime errors when using debug build

* fix additional runtime errors caused by unallocation variable

* allocate variable on all ranks

* fix the format issue

* fix MPI buffer allocation for debug builds

* Fix COMPGRID coordinate array mismatch in parallel postprocessing

* Fix integer overflow for NetCDF record axis delta

* fix ripforecast array mismatch error

* fix runupcalc float invalid error

* replace NWPSdir to HOMEnwps

* fix EVENTOUT shape mismatch error

* fix floating divide by zero error

* fix output conversion error

* remove all debug write statements

* fix dummy character variable 'TIMSTR' error

* fix unallocate variable XYTST error

* fix the variable 'bcfile_' without being defined error

* fix unallocate variables error in swanmain

* fix the array SPCSIG out-of-bound error

* fix runtime warning that an array temporary was created

* fix warning and format error

* fix out-of-bound error

* fix unallocate variable BLKNDC

* fix unallocate variables ICOUNT, IDSPLC, KGRPTC, and FLDC errors

* fix swan.exe runtime error: unallocate variable XYTST

* fix potential unallocate variable wlevl error

* fix punswan.exe unallocate variable XYTST error

* fix unallocate variable WLEVL errors in both structured and unstructured grid

---------

Co-authored-by: Ming Chen <ming.chen@dlogin09.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: Ming Chen <ming.chen@dlogin03.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: Ming Chen <ming.chen@dlogin01.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: Ming Chen <ming.chen@dlogin02.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: Ming Chen <ming.chen@dlogin05.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: Ming Chen <ming.chen@dlogin06.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: Ming Chen <ming.chen@dlogin07.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: Ming Chen <ming.chen@dlogin04.dogwood.wcoss2.ncep.noaa.gov>
* add error handling to nwps_wavetrack_cg1

* update for err_exit for ush/make_psurge_identify.sh

* error checks added for ush/make_psurge_final.sh

* plot_ship so far

* update shiproutes

* update datacheck

* Keep error messages to log

Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
…A-EMC#123)

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin02.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin07.dogwood.wcoss2.ncep.noaa.gov>
* initial commit to address bugzilla

* making changes to dev/scripts to remove any date references

* making changes to scripts to remove any date references

* remove 'date' from ecf script

* remaining jobs changes

* fixing date and replacing with prod_util variables in bash scripts

* perl script removing date variables

* error fix in perl

---------

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin09.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin02.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin06.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin01.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin06.dogwood.wcoss2.ncep.noaa.gov>
* updating crons for omd.wave parallel runs

* replace user with omd.wave

* more changes to crons to run on group account

* account for file name change

---------

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin03.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin06.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin06.dogwood.wcoss2.ncep.noaa.gov>
* unused file removal

* remove line instead of comment

* remove unused file from psurge dir

---------

Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin05.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@dlogin03.dogwood.wcoss2.ncep.noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants