close #213. feat(escrow): add protocol fee with treasury distribution#277
Open
techAlhaji wants to merge 1 commit into
Open
close #213. feat(escrow): add protocol fee with treasury distribution#277techAlhaji wants to merge 1 commit into
techAlhaji wants to merge 1 commit into
Conversation
- introduce Admin, DaoAddress, and FeeBps state - implement init_contract for secure initialization - deduct protocol fee during release and send to treasury - add admin functions to update fee and DAO address with validation - enforce fee cap and safe arithmetic - update events to include fee amount - add tests for fee logic, admin controls, and edge cases
|
@techAlhaji Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
PLEASE LOOK IN TO CI @techAlhaji |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #213
This PR introduces a protocol fee mechanism to the escrow contract. A configurable fee (in basis points) is deducted during release() and sent to a treasury address, ensuring sustainable platform revenue.
It adds secure contract initialization, admin-controlled fee and DAO configuration with validation, and updates events for transparency. Comprehensive tests cover fee calculation, edge cases, and access control.