feat(geolocation): implement address sanitization and caching to prev…#278
Open
Opulencechuks wants to merge 2 commits into
Open
feat(geolocation): implement address sanitization and caching to prev…#278Opulencechuks wants to merge 2 commits into
Opulencechuks wants to merge 2 commits into
Conversation
…ent injection and reduce API costs
|
@Opulencechuks Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
@Opulencechuks , U MIGHT WANT TO LOOK IN TO CI , ITS FAILING |
Author
|
please merge this issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #206
PR Description
Title: feat(geolocation): implement address sanitization and caching
Description:
This PR addresses security and cost concerns in the geocoding service by implementing input sanitization and result caching.
Key Changes:
geocode_addressthat cleans and validates raw address strings, preventing injection and rejecting invalid inputs (e.g., pure numbers, too short/long).How to Test:
1.Sanitization Check:
geocode_addressmethod (or use the artisan profile update endpoint) with various "bad" strings like:Nonewithout hitting the Nominatim API.2.Caching Check:
keys geocode:should show a new entry.3.Automated Test:
python backend/scratch/test_geocoding_improvements.py(requires local environment setup).Acceptance Criteria: