Feature/wallet context memory leak#283
Merged
gabito1451 merged 6 commits intoApr 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr closes #233
This PR addresses performance issues within
WalletContext.tsxcaused by redundant initializations and improper event listener cleanup. Previously, the component could instantiate multiple overlappingStellarWalletsKitinstances across remounts (especially noticeable in React 18 Strict Mode or during hot reloading), which led to memory leaks.Changes Included:
useRefto store the activekitRefinstance. The dynamic import logic now correctly short-circuits if the kit has already been initialized, preventing duplicate network module loads.isMountedflag within theuseEffectclosure to prevent state updates on an unmounted context wrapper.useEffectcleanup return block to safely invoke wallet event listener cleanup viaremoveEventListeners()ordisconnect()on unmount, fully preventing stale listeners from degrading performance.useMemoconfigurations to ensure the provider correctly caches the state valueconnect/disconnect/signTransactionfunctions strictly based on theiraddressandkitdependencies without causing unnecessary component re-renders.