AirflowNetwork network validation refactor #10349
Conversation
The content is being moved to a separate tool and this setup really didn't pan out as hoped, so to avoid duplication it makes sense to remove the files.
| enum class DuctLineType | ||
| { | ||
| Invalid = -1, | ||
| Unknown = 0, |
There was a problem hiding this comment.
Ummm, why Unknown = 0 as opposed to Invalid = -1 which is what we are doing everywhere else?
There was a problem hiding this comment.
See other longer comment, I'm trying to get all these to the point where they're not read in or ever possibly invalid.
| // TODO: enum check | ||
| Invalid = -1, | ||
| DOP = 1, // Detailed large opening component | ||
| Unknown = -1, |
There was a problem hiding this comment.
Why Unknown and not Invalid, which is what we are calling that spot everywhere else?
There was a problem hiding this comment.
The ultimate goal is to eliminate additional members entirely because it isn't read in through the input processor. It's currently needed because there's a helper data structure AirflowNetworkCompProp that I haven't managed to get rid of yet. The helper structure is used for some introspection-type things that should instead be asking the element itself what type it is via the type method. I changed it to 'Unknown' because it will never be invalid and the goal it to get rid of it anyway.
| HEX = 6, // Heat exchanger | ||
| RVD = 7, // Reheat VAV terminal damper | ||
| Num | ||
| Unknown = 0, |
There was a problem hiding this comment.
See other longer comment, I'm trying to get all these to the point where they're not read in or ever possibly invalid.
The AirflowNetwork_MultiAirLoopTest unit test now has a chunk commented out, that will need to be fixed before this can be merged.
|
@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated. |
1 similar comment
|
@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated. |
|
@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated. |
9 similar comments
|
@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated. |
|
@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated. |
|
@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated. |
|
@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated. |
|
@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated. |
|
@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated. |
|
@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated. |
|
@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated. |
|
@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated. |
|
@jasondegraw it has been 28 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
2 similar comments
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 8 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
2 similar comments
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
3 similar comments
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 14 days since this pull request was last updated. |
|
@jasondegraw it has been 9 days since this pull request was last updated. |
1 similar comment
|
@jasondegraw it has been 9 days since this pull request was last updated. |
|
@jasondegraw it has been 8 days since this pull request was last updated. |
|
@jasondegraw it has been 14 days since this pull request was last updated. |
|
@jasondegraw it has been 12 days since this pull request was last updated. |
|
@jasondegraw it has been 8 days since this pull request was last updated. |
1 similar comment
|
@jasondegraw it has been 8 days since this pull request was last updated. |
|
@jasondegraw it has been 10 days since this pull request was last updated. |
|
@jasondegraw it has been 12 days since this pull request was last updated. |
|
@jasondegraw it has been 20 days since this pull request was last updated. |
|
@jasondegraw it has been 13 days since this pull request was last updated. |
|
@jasondegraw it has been 22 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
2 similar comments
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
8 similar comments
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
|
@jasondegraw it has been 7 days since this pull request was last updated. |
Pull request overview
This PR refactors how the AirflowNetwork pressure network is validated. The diagnostic script is being removed from the repo and the content included in a separate Python tool that does additional validation. Some of validation done by the script (and now the Python tool) is probably not appropriate for the solver, so the focus is on things that have come up in the past. Additional checks may be added with an on/off switch (maybe in the AFN simulation control object) in the future.
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.