Skip to content

Conversation

@tanaya-mankad
Copy link
Collaborator

Pull request overview

Description of the purpose of this PR

The Kiva library has undergone several improvements, including a bump in the boost library dependency, since the last update 2 years ago. This PR is an effort to keep EnergyPlus up-to-date with Kiva 0.6.7, the latest tagged release.

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@tanaya-mankad tanaya-mankad self-assigned this Dec 24, 2025
@tanaya-mankad tanaya-mankad added the Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring label Dec 24, 2025
@github-actions
Copy link

⚠️ Regressions detected on ubuntu-24.04 for commit 85e1486

Regression Summary
  • EIO: 1
  • ESO Small Diffs: 1
  • Table Small Diffs: 1

@github-actions
Copy link

⚠️ Regressions detected on macos-14 for commit 85e1486

Regression Summary
  • EIO: 1
  • ESO Small Diffs: 1
  • Table Small Diffs: 1

@tanaya-mankad
Copy link
Collaborator Author

There are extremely minor regressions on Mac and Ubuntu, down in the 1e-12 range. This is not altogether unexpected, as the entire boost library has been updated, including all the geometry packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants