Repository navigation
added 99-pvscan which includes methods to get pv types - #20
Open
Dan Henriksen (dihenriksen) wants to merge 2 commits into
Open
Dan Henriksen (dihenriksen) wants to merge 2 commits into
Dan Henriksen (dihenriksen) wants to merge 2 commits into
Conversation
Dan Henriksen (dihenriksen)
marked this pull request as ready for review
February 5, 2026 20:30
Dan Henriksen (dihenriksen)
force-pushed
the
get-pv-types
branch
from
October 22, 2026 19:50
81a6273 to
9fcc433
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Datatype handling can abort exports, and discovery omits existing classic ophyd devices and signals.
2 open issues
What changed in this PR
Adds PV inventory helpers to the startup profile, mapping configured signals to their PV sources and datatypes.
Changes:
- Adds recursive signal discovery and enum metadata conversion.
- Provides device/signal mappings and a flat JSON export.
- Ignores the generated
pv_types.jsonfile.
| File | Description |
|---|---|
startup/99-pvscan.py |
Adds signal traversal, datatype conversion, and PV inventory export. |
.gitignore |
Excludes generated PV inventory output. |
Review effort: Balanced
Comment on lines
+77
to
+99
| if issubclass(signal._connector.backend.datatype, Enum) | ||
| else signal._connector.backend.datatype.__name__ | ||
| ), | ||
| } | ||
| for signal in walk_signals(device).values() | ||
| if isinstance(signal, Signal) | ||
| } | ||
| for device in devices | ||
| } | ||
| return pvs | ||
|
|
||
|
|
||
| def get_pv_types(): | ||
| """ | ||
| This is a dictionary that maps all of the PVs in the profile to their types. | ||
| """ | ||
|
|
||
| devices = [g for g in globals().values() if isinstance(g, Device)] | ||
| pv_types = { | ||
| signal.source: ( | ||
| enum_to_dict(signal._connector.backend.datatype) | ||
| if issubclass(signal._connector.backend.datatype, Enum) | ||
| else signal._connector.backend.datatype.__name__ |
| This is a dictionary that maps the Devices and Signals in the profile to their pvs and types. | ||
| """ | ||
|
|
||
| devices = [g for g in globals().values() if isinstance(g, Device)] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.