Repository navigation
Small change to avoid Vimba redefinition of the acquire PV - #37
Open
Thomas Hopkins (thopkins32) wants to merge 1 commit into
Open
Thomas Hopkins (thopkins32) wants to merge 1 commit into
Thomas Hopkins (thopkins32) wants to merge 1 commit into
Conversation
Dan Henriksen (dihenriksen)
force-pushed
the
small-vimba-acquire-change
branch
from
October 22, 2026 20:28
0941c3a to
a8f9a41
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The removed Annotated alias is still used by existing annotations and must be restored to avoid a startup failure.
1 open issue
What changed in this PR
This PR simplifies Vimba acquisition handling by using the standard driver instead of redefining the Acquire process variable.
Changes:
- Removes
CustomVimbaDriverIOand usesadvimba.VimbaDriverIOdirectly. - Restores the cached acquisition state by waiting for readback without requiring set completion.
- Updates imports and removes the explicit
TmpAdvimba.stats1annotation.
| File | Description |
|---|---|
startup/30-area-detectors.py |
Simplifies the Vimba driver and adjusts acquisition-state restoration. |
Review effort: Balanced
| @@ -1,17 +1,9 @@ | |||
| from typing import Annotated as A | |||
| from typing import Sequence | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dan Henriksen (@dihenriksen) I think this solution is a bit cleaner than what we settled on yesterday in #36
This is how it is done here: https://github.com/bluesky/ophyd-async/blob/1ce94eb9854a105d4890a50ad33f8c4e5e6c5c9b/src/ophyd_async/epics/adcore/_acquire_logic.py#L26-L33
I would test at the beamline before merging just to be sure.