started implementing slurm job submission from the gui #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielballan
reviewed
Nov 4, 2025
src/nsls2ptycho/core/ptycho_recon.py
Outdated
| pass | ||
|
|
||
|
|
||
| def submit_job(self): |
There was a problem hiding this comment.
As this evolves, it's worth keeping an eye on whether this actually needs any instance state (i.e. self.<X>). If not, it could just be a simple function, rather than a method, and that would make it simpler to test.
src/nsls2ptycho/core/ptycho_recon.py
Outdated
| "Authorization": f"Bearer {bearer_token}" | ||
| } | ||
|
|
||
| response = requests.post(url, headers=headers, json=payload) |
There was a problem hiding this comment.
We should use a stateful client instance (and httpx) as mentioned in Slack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.