Skip to content

feat: add pre-commit hook requirements and prohibit --no-verify - #3

Merged
heynemann merged 1 commit into
mainfrom
heynemann/pre-commit-hook
Nov 17, 2025
Merged

heynemann merged 1 commit into
mainfrom
heynemann/pre-commit-hook

Conversation

@heynemann

@heynemann heynemann commented Nov 17, 2025 •

Copy link
Copy Markdown
Contributor
  • Add mandatory requirement for scripts/pre-commit.sh in both wiz-auto and wiz-next
  • Add absolute prohibition against git commit --no-verify
  • Add lint error policy requiring fixes instead of ignores
  • Emphasize that pre-commit hooks must run before every commit

These changes enforce quality gates by ensuring:

  1. Pre-commit hooks exist and run automatically
  2. Skipping hooks via --no-verify is completely forbidden
  3. Lint errors must be fixed rather than ignored (unless genuinely not feasible)

Summary by CodeRabbit

  • Documentation

    • Updated internal development workflow documentation with enhanced process clarifications and guidelines.
  • Chores

    • Refined development standards and code quality enforcement procedures in process documentation.

Note: These updates are internal documentation changes with no direct user-facing impact.

- Add mandatory requirement for scripts/pre-commit.sh in both wiz-auto and wiz-next
- Add absolute prohibition against git commit --no-verify
- Add lint error policy requiring fixes instead of ignores
- Emphasize that pre-commit hooks must run before every commit

These changes enforce quality gates by ensuring:
1. Pre-commit hooks exist and run automatically
2. Skipping hooks via --no-verify is completely forbidden
3. Lint errors must be fixed rather than ignored (unless genuinely not feasible)
@coderabbitai

coderabbitai Bot commented Nov 17, 2025 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Updates to workflow documentation for AI-assisted command execution. Clarifies loop behavior, execution control, and milestone lifecycle in wiz-auto.md. Introduces mandatory pre-commit hooks, lint error policies, and commit workflow constraints in wiz-next.md. All changes are documentation-only.

Changes

Cohort / File(s) Summary
Workflow Documentation - Auto-execution
.cursor/commands/wiz-auto.md
Clarified infinite loop behavior and PROCEED/HALT execution flow; expanded critical behavior rules and stopping criteria; enhanced milestone lifecycle with mandatory analyst review and lookahead requirements; refined terminology around decision-making and output expectations
Workflow Documentation - Next Steps & Commit
.cursor/commands/wiz-next.md
Added mandatory pre-commit hook script requirement (scripts/pre-commit.sh); introduced dedicated LINT ERROR POLICY section with error handling and ignore guidelines; added ABSOLUTE PROHIBITION block enforcing pre-commit usage and clarifying commit procedures

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Both files are documentation-only updates with no functional code changes
  • Changes are primarily textual clarifications and mandatory guidance additions
  • Review should focus on verifying accuracy of described workflows and completeness of policy statements
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch heynemann/pre-commit-hook

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46c05ba and 974d9e7.

📒 Files selected for processing (2)
  • .cursor/commands/wiz-auto.md (26 hunks)
  • .cursor/commands/wiz-next.md (4 hunks)

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining why this PR is needed, why this solution was chosen, and what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

@heynemann
heynemann merged commit de0d2cf into main Nov 17, 2025
5 of 6 checks passed
@heynemann
heynemann deleted the heynemann/pre-commit-hook branch November 17, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant