feat(role-enforcement): skill bootstrap and riviere-cli 100% coverage#282
Draft
feat(role-enforcement): skill bootstrap and riviere-cli 100% coverage#282
Conversation
… skill prompt Add roleDefinitionsDir as a required config field with filesystem validation (directory exists, index.md exists, one .md per role). Create 13 role definition files for the riviere-cli pilot plus the role-enforcement skill prompt that agents read to classify and annotate code. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…dd-component Apply role enforcement to features/builder (16 files) and features/query (6 files). Refactor addComponent command to return typed result instead of mixing output concerns. Add queries layer to config. Document Promise<T> tool limitation in battle test log. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…files) Add role annotations to all cli-presentation files. Add cli-input-validator and cli-error roles for validation functions and CLI boundary errors. Add cli-presentation layer to config. Document enum limitation in battle test log. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…14 files) Apply role enforcement to extraction-config, graph-persistence, source-filtering, component-mapping, errors, platform/domain, and shell. Refactor builder-graph-loader to extract output-formatting functions into cli-presentation layer. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Simplify include patterns to cover all source files in riviere-cli. 80/80 non-test files pass enforcement with 0 errors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tions Mark all progress items complete. Add final numbers, tool limitations discovered, skill improvement opportunities, and 7 questions for user review. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roleDefinitionsDirto role enforcement config schema with filesystem validationpackages/riviere-role-enforcement/skills/role-enforcement.mdfor agents to apply role enforcement.tsfiles inriviere-cliwith@riviere-roleannotations (100% coverage)cli-input-validator,cli-errorsrc/**/*.ts— enforcement now catches any unannotated export in riviere-cliKey decisions for review
cli-input-validator,cli-error) were created by agents — need human approvalallowedOutputsremoved fromcommand-use-casedue toPromise<T>tool limitationpackages/riviere-role-enforcement/skills/BATTLE-TEST-LOG.mddocs/project/specs/role-enforcement-skill-bootstrap.mdTest plan
pnpm verifypasses (all 6 commits)pnpm nx test riviere-cli: 59/59 tests, 100% coveragepnpm nx test riviere-role-enforcement: 19/19 config + CLI tests pass🤖 Generated with Claude Code