Repository navigation
feat(Rounds): count down 5 seconds on the phones before closing - #12
Merged
Merged
Conversation
- 收卷 now stores closeAt and sets a Durable Object alarm; the alarm closes, grades and scores the round - The round stays open meanwhile, so answers sent during the countdown still count; pressing again does not restart it - Player state carries closeIn, the milliseconds left, so phones count down without trusting their own clocks - Tests fire the alarm themselves and cover answering and reopening during the countdown
- A red 收卷倒數 pill under the top bar counts down, popping a new number each second, and leaves the answer form usable - The countdown closes the history sheet, and the close push hides it as TIME'S UP plays - No alert for an answer rejected once 收卷 has started, so it cannot block the reveal
- The dashboard's status pill turns red with 收卷中 until the round closes - 收卷並計分 stays disabled on the dashboard and /host while counting down, and the toast reads 開始收卷倒數 - The pages refresh from the close push instead of right after the click
- Note the closing countdown under the animations feature and in step 3 of the game flow, in both languages
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closeIn(the time left, so the phone's clock does not matter); the answer form stays usable, the history sheet closes, and TIME'S UP plays as beforeTest plan
npm test, with tests that fire the alarm and cover answering and reopening during the countdown; making 收卷 close at once again fails themwrangler dev, from the dashboard: the countdown starts at 5, the round closes about 5.3 s after the click, and a title sent mid-countdown scored