feat(player): add Share to the track menu - #73
Merged
Merged
Conversation
Copy the music.youtube.com watch URL, with a textarea fallback for WebViews that block navigator.clipboard.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://music.youtube.com/watch?v=<id>to the clipboard.copyToClipboardwith a hidden-textarea +execCommand("copy")fallback for WebViews that blocknavigator.clipboard— the same path the artist-page Share button already uses.Why
Artist pages already have Share. Songs and videos did not, so the only way to grab a link was to leave the app.
Scope
Frontend-only, rebased cleanly on
v0.4.4/ currentorigin/main. Independent of the lyrics (#71), chapters (#72), macOS, WEB_REMIX, and speed PRs.Test plan
tsc --noEmitmusic.youtube.com/watch?v=…URLNotes
Does not change the artist-page Share button; that already copies the channel URL.