feat(now-playing): add immersive full-screen karaoke overlay - #76
Open
TavoNiievez wants to merge 1 commit into
Open
TavoNiievez wants to merge 1 commit into
TavoNiievez wants to merge 1 commit into
Conversation
A full-window "Now Playing" screen: full-size album cover on the left, centered full-size synced karaoke lyrics on the right, over a blurred copy of the cover. Opened by an expand button on the player cover (both the right card and the bottom bar), closed with its chevron-down button or Esc. Reuses the existing player stack rather than adding new logic: - the playback + scrub stores drive transport and the progress slider; - ProgressSlider / VolumeControl / useITunesCover are imported from the player bar; the transport cluster is inlined (the two bars are left untouched so their differing layouts don't regress); - the LyricsBody / useLyricsView karaoke engine already highlights the active line, auto-scrolls, and seeks on line click. Details: - New non-persisted store (now-playing.ts) holds the open flag, so it never survives a reload or leaks across windows via the shared layout key. - Overlay is portaled to <body> and the app root is marked `inert` while open (background out of the tab order + a11y tree) - modal focus with focus-in/restore and no focus-trap library. Reused components are forced into a `dark` token context so they stay legible over the dark backdrop; a ~55% scrim + text-shadow keep lyrics readable over bright covers; reduced-motion is respected on the open animation. - Positioned below the 36px title bar so the OS window controls stay usable; auto-closes (and resets the flag) when the queue empties; the expand button is suppressed in the floating window. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A full-window "Now Playing" screen: full-size album cover on the left, centered full-size synced karaoke lyrics on the right, over a blurred copy of the cover. Opened by an expand button on the player cover (both the right card and the bottom bar), closed with its chevron-down button or Esc.
Reuses the existing player stack rather than adding new logic:
Details:
inertwhile open (background out of the tab order + a11y tree) - modal focus with focus-in/restore and no focus-trap library. Reused components are forced into adarktoken context so they stay legible over the dark backdrop; a ~55% scrim + text-shadow keep lyrics readable over bright covers; reduced-motion is respected on the open animation.