feat(player): add Go to album to the track menu - #93
Open
mihaimetal wants to merge 2 commits into
Open
mihaimetal wants to merge 2 commits into
mihaimetal wants to merge 2 commits into
Conversation
Show the item when the current track has an album browse id, and keep that id on queued tracks so the player overflow menu can open /album/$id.
Most play sources never put an album browse id on the queued track, so the player ⋮ item stayed hidden even for album songs. Read MPREb_ ids and the row's own Go to album menu, and look the current track up via /next when the queue still has no id.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Go to album item next to Go to artist in the track context menu, the player ⋮ overflow, and the cover menu.
It only shows when the current track belongs to an album (browse id
MPREb_…). Opening it navigates to/album/$id. From the floating player it emitsnav:albumand focuses the main window, same as Go to artist.Album-page rows already stamp their browse id onto queued tracks. Other play sources often omit it, so we also:
MPREb_…from bylines even withoutpageType/nextwhen the queue still has no idSingles / videos with no album still omit the item.