Skip to content

Add the NVSkills CI workflow#6374

Open
rostan-t wants to merge 1 commit into
mainfrom
rostan-t/skill-onboarding
Open

Add the NVSkills CI workflow#6374
rostan-t wants to merge 1 commit into
mainfrom
rostan-t/skill-onboarding

Conversation

@rostan-t
Copy link
Copy Markdown
Collaborator

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

Add the NVSkills CI workflow to request skill validation.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@rostan-t
Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 27, 2026

Greptile Summary

This PR adds a new GitHub Actions workflow (request-nvskills-ci.yml) that hooks into the NVSkills skill-validation CI system. The workflow can be triggered either by an issue_comment event (when someone comments /nvskills-ci on a PR) or by a push event from a designated bot actor with a matching commit message prefix.

  • Adds the request-nvskills-ci.yml workflow with two trigger paths: a chatops-style comment command and a bot-push path, both guarded by a conditional if expression that prevents unnecessary job runs.
  • Delegates the actual work to the reusable NVIDIA/skills/.github/workflows/team-request.yml@main workflow, passing only the NVSKILLS_CI_DISPATCH_TOKEN secret and requesting minimal read-only permissions (contents: read, pull-requests: read).

Confidence Score: 5/5

Safe to merge — the change is a single new workflow file with no impact on existing code paths.

The workflow is a small, self-contained addition that delegates all work to the upstream reusable workflow. Permissions are read-only, the conditional guards are logically correct, and the secret forwarding follows standard GitHub Actions patterns.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/request-nvskills-ci.yml New workflow adding NVSkills CI integration; triggers and conditional logic look correct, permissions follow least-privilege, and secret forwarding is standard.

Sequence Diagram

sequenceDiagram
    participant User
    participant Bot as nv-skills-ci[bot]
    participant GH as GitHub Actions
    participant RW as NVIDIA/skills team-request.yml

    User->>GH: Comment /nvskills-ci on PR
    GH->>GH: issue_comment trigger (check: is PR comment, starts with /nvskills-ci)
    GH->>RW: "uses: team-request.yml@main, secrets: NVSKILLS_CI_DISPATCH_TOKEN"

    Bot->>GH: "Push commit (actor == NVSKILLS_SIGNATURE_PUSH_ACTOR)"
    GH->>GH: push trigger (check: actor match, commit title match)
    GH->>RW: "uses: team-request.yml@main, secrets: NVSKILLS_CI_DISPATCH_TOKEN"
Loading

Reviews (4): Last reviewed commit: "Add NVSkills CI workflow" | Re-trigger Greptile

Comment thread .github/workflows/request-nvskills-ci.yml
Comment thread .github/workflows/request-nvskills-ci.yml
@rostan-t rostan-t changed the title Rostan t/skill onboarding Skill onboarding May 27, 2026
@rostan-t rostan-t changed the title Skill onboarding Add the NVSkills CI workflow May 27, 2026
@JanuszL
Copy link
Copy Markdown
Contributor

JanuszL commented May 27, 2026

/nvskills-ci

@rostan-t rostan-t force-pushed the rostan-t/skill-onboarding branch from b2d0b97 to bdbe556 Compare May 27, 2026 12:18
@JanuszL JanuszL self-assigned this May 27, 2026
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
@rostan-t rostan-t force-pushed the rostan-t/skill-onboarding branch from bdbe556 to 392a069 Compare May 27, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants