Skip to content

Make skills/ the source of truth for skills#6375

Open
rostan-t wants to merge 3 commits into
mainfrom
rostan-t/update-skill
Open

Make skills/ the source of truth for skills#6375
rostan-t wants to merge 3 commits into
mainfrom
rostan-t/update-skill

Conversation

@rostan-t
Copy link
Copy Markdown
Collaborator

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

The skills verification workflow requires skills/ to be the source of truth. This PR does this and makes .agents/skills a symlink.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@rostan-t rostan-t marked this pull request as ready for review May 28, 2026 07:57
rostan-t added 2 commits May 28, 2026 08:00
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
@rostan-t rostan-t force-pushed the rostan-t/update-skill branch from f9baa5c to 2f5d59a Compare May 28, 2026 08:00
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 28, 2026

Greptile Summary

This PR reorganizes the skill file layout so that skills/ becomes the canonical source of truth instead of .agents/skills/. The .agents/skills entry is converted from a real directory to a symlink pointing at ../skills, and .claude/skills is updated to also point directly at ../skills (removing the now-redundant chain through .agents/skills).

  • Files from .agents/skills/dali-dynamic-mode/ are moved to skills/dali-dynamic-mode/, and three new artifacts are added: BENCHMARK.md (Tier 1/2 evaluation report from NVSkills-Eval), skill-card.md (publication metadata), and skill.oms.sig (Sigstore cryptographic signature).
  • SKILL.md receives a minor addition: license: Apache-2.0 in its frontmatter metadata.

Confidence Score: 5/5

Safe to merge — the change only reorganizes skill metadata files and symlinks, with no modifications to DALI library code.

All changes are structural: actual skill content files move from .agents/skills/ to skills/, symlinks are updated to point directly at the new location, and three new documentation/signature artifacts are added. No library code, tests, or build scripts are touched.

No files require special attention.

Important Files Changed

Filename Overview
.agents/skills Converted from a real directory to a symlink pointing at ../skills; breaks the old chain and keeps backward compatibility for any tool that resolved through .agents/skills.
.claude/skills Symlink target updated from ../.agents/skills to ../skills, eliminating the double-hop and aligning with the new source-of-truth layout.
skills/dali-dynamic-mode/SKILL.md Renamed from .agents/skills/dali-dynamic-mode/SKILL.md; only change is the addition of license: Apache-2.0 in the YAML frontmatter.
skills/dali-dynamic-mode/skill.oms.sig New Sigstore bundle signing the five skill content files; serialization config correctly uses allow_symlinks: false and method: files.
skills/dali-dynamic-mode/BENCHMARK.md New NVSkills-Eval Tier 1/2 report; overall verdict PASS with minor informational findings (missing metadata.author, metadata.tags, and optional sections).
skills/dali-dynamic-mode/skill-card.md New publication metadata card; references the NVSkills-Eval profile and lists standard NVIDIA AI Concerns reporting link.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["skills/dali-dynamic-mode/\n(source of truth)"] --> B["SKILL.md\nBENCHMARK.md\nskill-card.md\nskill.oms.sig\nevals/"]

    C[".agents/skills"] -->|symlink ../skills| A
    D[".claude/skills"] -->|symlink ../skills| A

    subgraph Before
        E[".agents/skills/dali-dynamic-mode/\n(actual files)"]
        F[".claude/skills"] -->|symlink ../.agents/skills| E
    end

    subgraph After
        A
        C
        D
    end
Loading

Reviews (2): Last reviewed commit: "Attach NVSkills validation signatures" | Re-trigger Greptile

@JanuszL
Copy link
Copy Markdown
Contributor

JanuszL commented May 28, 2026

/nvskills-ci

@rostan-t
Copy link
Copy Markdown
Collaborator Author

!build

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@dali-automaton
Copy link
Copy Markdown
Collaborator

CI MESSAGE: [52901332]: BUILD FAILED

@dali-automaton
Copy link
Copy Markdown
Collaborator

CI MESSAGE: [52902360]: BUILD FAILED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants