Repository navigation
[merge-to-it] sharpa_avatar: judge glove liveness by fetched data, not the online flag (#1181) - #1198
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe plugin now uses sample timestamps to determine whether fetched glove data is new. Repeated samples do not refresh the liveness timer. The timer resets the glove after three seconds without a newer sample. Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to No concrete runtime failure is established by the available evidence. The change presents no supported merge-blocking risk beyond normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
sgrizan-nv
reviewed
Oct 7, 2026
sgrizan-nv
approved these changes
Oct 7, 2026
Base automatically changed from
merge-to-it/sharpa-avatar-detect-silent-glove
to
main
October 8, 2026 19:05
…t the online flag AvatarDevice::get_device_info().online stays false for a glove first discovered offline and powered on later, so such a glove was started and then stopped every 2 s. refresh_data() no longer checks that flag; a glove is disconnected only after the data timeout. Workaround for #1181. Signed-off-by: Lotus Li <lotusl@nvidia.com>
…stamps With --datasets=haptic nothing dropped a glove's handle once the online reset was removed: the data timeout was gated on a data dataset and set_task() failures only log. A power-cycled glove kept its dead handle, which blocked reconnection. A haptic-only glove now fetches RAW so the same stamp-based data timeout applies to every configuration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Lotus Li <lotusl@nvidia.com>
lotusl-code
force-pushed
the
merge-to-it/sharpa-avatar-liveness-by-data
branch
from
October 8, 2026 21:42
cf8860e to
0c87e8a
Compare
lotusl-code
enabled auto-merge (squash)
October 8, 2026 21:54
lotusl-code
added a commit
that referenced
this pull request
Oct 9, 2026
* [merge-to-it] sharpa_avatar: pin only the primary APT signing key fingerprint (#1196) install_avatar_sdk.sh failed its key check because it also required F9A50A81FE8797F953DB24E1938548788D899BCC, which is the encryption subkey of the Sharpa signing key, while the check reads primary fingerprints only. Pin the primary key alone. Signed-off-by: Lotus Li <lotusl@nvidia.com> * [merge-to-it] sharpa_avatar: detect a silent glove by new sample stamps (#1197) fetch_data() keeps returning a silent glove's last sample, so a glove that stopped sending data still counted as fetched and the data timeout never fired. Only a sample whose stamp advances now counts as data, and the timeout drops from 10 s to 3 s. Signed-off-by: Lotus Li <lotusl@nvidia.com> * [merge-to-it] sharpa_avatar: judge glove liveness by fetched data, not the online flag (#1181) (#1198) * [merge-to-it] sharpa_avatar: judge glove liveness by fetched data, not the online flag AvatarDevice::get_device_info().online stays false for a glove first discovered offline and powered on later, so such a glove was started and then stopped every 2 s. refresh_data() no longer checks that flag; a glove is disconnected only after the data timeout. Workaround for #1181. Signed-off-by: Lotus Li <lotusl@nvidia.com> * [merge-to-it] sharpa_avatar: time out a haptic-only glove by its RAW stamps With --datasets=haptic nothing dropped a glove's handle once the online reset was removed: the data timeout was gated on a data dataset and set_task() failures only log. A power-cycled glove kept its dead handle, which blocked reconnection. A haptic-only glove now fetches RAW so the same stamp-based data timeout applies to every configuration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Lotus Li <lotusl@nvidia.com> --------- Signed-off-by: Lotus Li <lotusl@nvidia.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> --------- Signed-off-by: Lotus Li <lotusl@nvidia.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[merge-to-it]
Summary
Workaround for #1181:
AvatarDevice::get_device_info().onlinestays false for a glove first discovered offline and powered on later, sorefresh_data()stopped such a glove on every frame and it was reconnected every 2 s indefinitely. Liveness is now judged by fetched data only; a glove is disconnected after the data timeout.Stacked on #1197 (target branch
merge-to-it/sharpa-avatar-detect-silent-glove): without that change a powered-off glove would keep "fetching" its last sample and never time out.Testing
clang-format-14 --dry-run --Werror; pre-commit;-fsyntax-onlycompile against Avatar SDK 1.7.3-17 headers.🤖 Generated with Claude Code
Summary by CodeRabbit