[merge-to-it] sharpa_avatar: log through isaaccapture::Logger

[lotusl-code]

[merge-to-it]

Summary

The sharpa_avatar plugin printed through std::cout/std::cerr, which a launched plugin's fd 1/2 send to the native capture file, so none of it reached the console. It now logs through isaaccapture::Logger:

• isaaccapture.plugins.sharpa_avatar (app/main.cpp) and isaaccapture.plugins.sharpa_avatar.AvatarTracker (core);
• new lines for a glove timing out and for why the plugin exits (signal or error);
• "Waiting for an online glove..." is logged once per stretch without a glove (re-armed when a glove connects) instead of every 10 s.

log_bridge reaches the plugin through oxr::oxr_core's public link, so no CMake change is needed.

Testing

• clang-format-14 --dry-run --Werror; pre-commit; -fsyntax-only compile of both translation units against Avatar SDK 1.7.3-17 headers.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Improvements
  • Startup, shutdown, argument warnings, and exception messages are now reported through the application’s logging system.
  • Hand-tracking status and diagnostic messages—including glove connections, timeouts, and haptic command failures—are also logged consistently.
  • While no glove is connected, the wait notice appears once per disconnected period. Reconnecting resets the notice for any later disconnection.
  • Glove retry timing and existing shutdown and error outcomes remain unchanged.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 62139435-a68c-4c87-8018-7ec0d20bbf36

📥 Commits

Reviewing files that changed from the base of the PR and between 6960d4a and 89ff1b6.

📒 Files selected for processing (3)

• src/plugins/sharpa_avatar/app/main.cpp
• src/plugins/sharpa_avatar/core/avatar_hand_tracking_plugin.cpp
• src/plugins/sharpa_avatar/core/inc/avatar/avatar_hand_tracking_plugin.hpp

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The application and hand-tracking plugin now send messages through loggers instead of standard output and error streams. The tracker logs one waiting message during each stretch without a connected glove. A glove connection resets the waiting-message state. Existing retry timing, timeout handling, haptic error suppression, and exception exit results remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 89ff1

Application and tracker messages now use the logger, and the Logger implementation is linked into the application target. No concrete merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: routing sharpa_avatar logs through isaaccapture::Logger.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}