Skip to content

[merge-to-it] manus: log one "start streaming" line when a glove connects - #1200

Merged
lotusl-code merged 2 commits into
mainfrom
merge-to-it/manus-start-streaming-log
Oct 8, 2026
Merged

lotusl-code merged 2 commits into
mainfrom
merge-to-it/manus-start-streaming-log

Conversation

@lotusl-code

@lotusl-code lotusl-code commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

[merge-to-it]

Summary

A connecting Manus glove now logs <Side> glove connected (ID n); start streaming. when the landscape assigns it, mirroring the existing disconnect line. The calibration success line moves to debug (its failure warning stays) and the once-per-run <side> sensors=on line, which never re-appeared after a reconnect, is removed.

Testing

  • clang-format-14 --dry-run --Werror; pre-commit; -fsyntax-only compile of manus_hand_tracking_plugin.cpp: the only Manus SDK available locally is older than the one main targets, so main itself reports one SDK-signature error (CoreSdk_GetRawSkeletonNodeCount); this branch reports exactly the same diagnostics as main and none on changed lines.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Calibration success messages are now logged at a less prominent level.
    • Glove connection messages no longer include the previous streaming-status wording.
    • Removed a one-time sensor-status message for fully equipped sensor packs. Sensor-count checks and subsequent publishing are unchanged.

…ects

A connecting glove now logs "<Side> glove connected (ID n); start
streaming." when the landscape assigns it. The calibration success line
moves to debug and the once-per-run "<side> sensors=on" line is removed.

Signed-off-by: Lotus Li <lotusl@nvidia.com>
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: a4987537-9562-405d-a137-9df3209742a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 0a265505-011d-4b1d-bdba-3b1985dfa78d
📥 Commits

Reviewing files that changed from the base of the PR and between 6960d4a and 2623048.

📒 Files selected for processing (2)
  • src/plugins/manus/core/inc/manus/manus_hand_tracking_plugin.hpp
  • src/plugins/manus/core/manus_hand_tracking_plugin.cpp
💤 Files with no reviewable changes (1)
  • src/plugins/manus/core/inc/manus/manus_hand_tracking_plugin.hpp

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The Manus tracker removes its per-side sensor logging flag. Successful glove calibration messages use debug severity. Left and right glove connection messages no longer include “start streaming.” The tracker no longer emits the one-time sensors=on message after the five-sensor minimum check. Sensor pose construction and publishing remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 26230

The tracker logging changes match the stated behavior, including the requested connection messages. No concrete merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: logging one start-streaming line when a glove connects.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Comment thread src/plugins/manus/core/manus_hand_tracking_plugin.cpp
manus.rst still said the plugin logs sensors=on once per side. Remove
that sentence, and point the "No data received" row at the
"<Side> glove connected (ID n); start streaming." line instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Lotus Li <lotusl@nvidia.com>
@lotusl-code
lotusl-code enabled auto-merge (squash) October 8, 2026 22:10
@lotusl-code
lotusl-code merged commit f9deaa5 into main Oct 8, 2026
38 checks passed
@lotusl-code
lotusl-code deleted the merge-to-it/manus-start-streaming-log branch October 8, 2026 22:13
github-actions Bot added a commit that referenced this pull request Oct 8, 2026

This branch was successfully deployed

1 active deployment
dev — 7ece3b18 Deployed Oct 8, 2026 by lotusl-code via publish-wheel #5406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants