Repository navigation
[merge-to-it] manus: log one "start streaming" line when a glove connects - #1200
Conversation
…ects A connecting glove now logs "<Side> glove connected (ID n); start streaming." when the landscape assigns it. The calibration success line moves to debug and the once-per-run "<side> sensors=on" line is removed. Signed-off-by: Lotus Li <lotusl@nvidia.com>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe Manus tracker removes its per-side sensor logging flag. Successful glove calibration messages use debug severity. Left and right glove connection messages no longer include “start streaming.” The tracker no longer emits the one-time Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The tracker logging changes match the stated behavior, including the requested connection messages. No concrete merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
manus.rst still said the plugin logs sensors=on once per side. Remove that sentence, and point the "No data received" row at the "<Side> glove connected (ID n); start streaming." line instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Lotus Li <lotusl@nvidia.com>
[merge-to-it]
Summary
A connecting Manus glove now logs
<Side> glove connected (ID n); start streaming.when the landscape assigns it, mirroring the existing disconnect line. The calibration success line moves to debug (its failure warning stays) and the once-per-run<side> sensors=online, which never re-appeared after a reconnect, is removed.Testing
clang-format-14 --dry-run --Werror; pre-commit;-fsyntax-onlycompile ofmanus_hand_tracking_plugin.cpp: the only Manus SDK available locally is older than the onemaintargets, somainitself reports one SDK-signature error (CoreSdk_GetRawSkeletonNodeCount); this branch reports exactly the same diagnostics asmainand none on changed lines.🤖 Generated with Claude Code
Summary by CodeRabbit