Skip to content

Allow publishing a1 builds from main to pypi.nvidia.com - #1247

Merged
aristarkhovNV merged 1 commit into
mainfrom
aaristarkhov/publish-a1
Oct 13, 2026
Merged

aristarkhovNV merged 1 commit into
mainfrom
aaristarkhov/publish-a1

Conversation

@aristarkhovNV

@aristarkhovNV aristarkhovNV commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Description

a1 builds triggered by push to main will publish to pypi.nvidia.com

Fixes #(issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read and understood the contribution guidelines
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix/feature works (or explained why not)
  • I have signed off all my commits (git commit -s) per the DCO

Summary by CodeRabbit

  • Chores
    • Updated build publishing so successful wheel publications from push events can trigger kitmaker runs; pull requests no longer do.
    • Enabled uploads for main-branch builds, labeled as alpha versions, alongside release-branch builds labeled as release candidates and version-tag builds.

Signed-off-by: Andrei Aristarkhov <aaristarkhov@nvidia.com>
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 615fbf1b-7b76-43b9-8ef3-1a59aaac8946

📥 Commits

Reviewing files that changed from the base of the PR and between bc655b2 and 5c3543a.


📒 Files selected for processing (1)
  • .github/workflows/build-ubuntu.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.



📝 Walkthrough

Walkthrough

The workflow now runs the kitmaker job only on push events after successful wheel publication. It enables KITMAKER_UPLOAD for main-branch builds, release branches, and version tags. The kitmaker-status job runs when kitmaker succeeds.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes


Merge Risk: ⚪ Minimal · up to 5c354

Main-branch a1 uploads can proceed after wheel publication succeeds; the reviewed changes establish no actionable merge risk.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: publishing a1 builds from main to pypi.nvidia.com.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@aristarkhovNV
aristarkhovNV merged commit e4b0bdc into main Oct 13, 2026
35 checks passed
@aristarkhovNV
aristarkhovNV deleted the aaristarkhov/publish-a1 branch October 13, 2026 18:15

This branch was successfully deployed

1 active deployment
dev — 5c3543ae Deployed Oct 12, 2026 by aristarkhovNV via publish-wheel #5539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants