Repository navigation
馃崚 refactor(soma): rename handedness to hand side - #1249
Merged
nv-mhaselton merged 1 commit intoOct 13, 2026
Merged
Conversation
Rename SomaHandedness to SomaHandSide and handedness to hand_side to distinguish anatomical hand side from coordinate-system handedness. Update schemas, bindings, sources, examples, tests, and docs, and regenerate schema goldens. Signed-off-by: Michael Haselton <mhaselton@nvidia.com> (cherry picked from commit 5ee8f28)
Contributor
|
馃摑 Docs preview is not auto-deployed for fork PRs. A maintainer with write access to |
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the 鈿欙笍 Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
nv-jakob
approved these changes
Oct 12, 2026
jiwenc-nv
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport 5ee8f286e into release/1.6.x.
Follow-up to #1207.
Rename
SomaHandednesstoSomaHandSideandhandednesstohand_sideto distinguish anatomical left/right hand selection from coordinate-system handedness. This also aligns with existing IC retargeters and examples.Update the schemas, Python bindings and exports, sources, publishers, viewer, tests, and documentation. Regenerate the affected schema goldens.
This is a direct API rename within unreleased SOMA support. Coordinate conventions and pose behavior are unchanged.
Type of change
Testing
Validated native schema tests, Python schema/source tests, body and hand publisher/viewer tests with SOMA-X v0.3.1 assets, mypy, documentation, and formatting checks.
To reproduce the automated checks from a configured development checkout:
.venv/bin/cmake --build build \ --target schema_tests python_package -j4 .venv/bin/ctest --test-dir build \ -R '^(schema_|retargeting_test_soma_|retargeting_mypy_type_check|deviceio_live_view_test_soma_viewer|soma_(body|hand)_publisher_test_publisher)' \ --output-on-failure make -C docs current-docs SKIP=check-copyright-year pre-commit run --all-filesChecklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCO