Skip to content

馃崚 refactor(soma): rename handedness to hand side - #1249

Merged
nv-mhaselton merged 1 commit into
NVIDIA:release/1.6.xfrom
nv-mhaselton:backport/soma-hand-side-1.6
Oct 13, 2026
Merged

nv-mhaselton merged 1 commit into
NVIDIA:release/1.6.xfrom
nv-mhaselton:backport/soma-hand-side-1.6

Conversation

@nv-mhaselton

Copy link
Copy Markdown
Contributor

Description

Backport 5ee8f286e into release/1.6.x.

Follow-up to #1207.

Rename SomaHandedness to SomaHandSide and handedness to hand_side to distinguish anatomical left/right hand selection from coordinate-system handedness. This also aligns with existing IC retargeters and examples.

Update the schemas, Python bindings and exports, sources, publishers, viewer, tests, and documentation. Regenerate the affected schema goldens.

This is a direct API rename within unreleased SOMA support. Coordinate conventions and pose behavior are unchanged.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

Validated native schema tests, Python schema/source tests, body and hand publisher/viewer tests with SOMA-X v0.3.1 assets, mypy, documentation, and formatting checks.

To reproduce the automated checks from a configured development checkout:

.venv/bin/cmake --build build \
  --target schema_tests python_package -j4

.venv/bin/ctest --test-dir build \
  -R '^(schema_|retargeting_test_soma_|retargeting_mypy_type_check|deviceio_live_view_test_soma_viewer|soma_(body|hand)_publisher_test_publisher)' \
  --output-on-failure

make -C docs current-docs

SKIP=check-copyright-year pre-commit run --all-files

Checklist

  • I have read and understood the contribution guidelines
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix/feature works (or explained why not)
  • I have signed off all my commits (git commit -s) per the DCO

Rename SomaHandedness to SomaHandSide and handedness to hand_side
to distinguish anatomical hand side from coordinate-system handedness.

Update schemas, bindings, sources, examples, tests, and docs,
and regenerate schema goldens.

Signed-off-by: Michael Haselton <mhaselton@nvidia.com>
(cherry picked from commit 5ee8f28)
@nv-mhaselton nv-mhaselton self-assigned this Oct 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

馃摑 Docs preview is not auto-deployed for fork PRs.

A maintainer with write access to NVIDIA/IsaacCapture can deploy a preview by
commenting /preview-docs on this PR. Once deployed, the preview
will live at:

https://nvidia.github.io/IsaacCapture/preview/pr-1249/

@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

鈿欙笍 Run configuration
  • Configuration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 13365a5b-383b-4304-8383-a1dbb1682e38

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 馃攳 Trigger review
  • Autofix 路 Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@nv-mhaselton nv-mhaselton changed the title refactor(soma): rename handedness to hand side 馃崚 refactor(soma): rename handedness to hand side Oct 12, 2026
@nv-mhaselton
nv-mhaselton merged commit 8c6f811 into NVIDIA:release/1.6.x Oct 13, 2026
34 checks passed
@nv-mhaselton
nv-mhaselton deleted the backport/soma-hand-side-1.6 branch October 13, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants