Repository navigation
docs(cloudxr): document the client timeout env vars and test that 0 passes through - #1258
Closed
gareth-morgan-nv wants to merge 1 commit into
Closed
gareth-morgan-nv wants to merge 1 commit into
gareth-morgan-nv wants to merge 1 commit into
Conversation
…asses through TELEOP_CLIENT_STREAM_ATTACH_TIMEOUT_MS, TELEOP_CLIENT_WARMUP_BEGIN_TIMEOUT_MS and TELEOP_CLIENT_WARMUP_END_TIMEOUT_MS already reach the headset URL but were missing from the OOB env var table. Document them, including that 0 disables detection, and add a test that a 0 value survives env parsing and URL building. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
gareth-morgan-nv
requested review from
AndreusNvidius,
sgrizan-nv and
tengw-nv
October 13, 2026 19:02
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #1257 (base is that PR's branch, so the diff here is only this commit).
TELEOP_CLIENT_STREAM_ATTACH_TIMEOUT_MS,TELEOP_CLIENT_WARMUP_BEGIN_TIMEOUT_MSandTELEOP_CLIENT_WARMUP_END_TIMEOUT_MSalready reach the headset URL, but were missing from the OOB env var table.oob_teleop_control.rst, including that0disables detection.TELEOP_CLIENT_WARMUP_END_TIMEOUT_MS=0turns off all warm-up detection, which is what you want when the OpenXR application starts after the headset connects: until it submits frames the server sends only idle frames, which the client cannot tell apart from a stuck warm-up.test_zero_warmup_timeout_env_reaches_bookmark_urlchecks that a0value survives env parsing and URL building, so it is not dropped as falsy.No behavior change in Python; the env-var plumbing is already on
main.Test plan
test_oob_teleop_env.py/test_oob_teleop_adb.pypass (5 selected)SKIP=check-copyright-year pre-commit run --all-filespasses0as "disabled" once fix(webxr): let 0 disable the stream-attach and warm-up timeouts #1257 is in; until then use a large value such as2147483647🤖 Generated with Claude Code