Skip to content

docs(cloudxr): document the client timeout env vars and test that 0 passes through - #1258

Closed
gareth-morgan-nv wants to merge 1 commit into
gmorgan/webxr-zero-disables-startup-timeoutsfrom
gmorgan/oob-client-warmup-timeout
Closed

gareth-morgan-nv wants to merge 1 commit into
gmorgan/webxr-zero-disables-startup-timeoutsfrom
gmorgan/oob-client-warmup-timeout

Conversation

@gareth-morgan-nv

Copy link
Copy Markdown
Contributor

Summary

Stacked on #1257 (base is that PR's branch, so the diff here is only this commit).

TELEOP_CLIENT_STREAM_ATTACH_TIMEOUT_MS, TELEOP_CLIENT_WARMUP_BEGIN_TIMEOUT_MS and TELEOP_CLIENT_WARMUP_END_TIMEOUT_MS already reach the headset URL, but were missing from the OOB env var table.

  • Docs: add the three variables to oob_teleop_control.rst, including that 0 disables detection. TELEOP_CLIENT_WARMUP_END_TIMEOUT_MS=0 turns off all warm-up detection, which is what you want when the OpenXR application starts after the headset connects: until it submits frames the server sends only idle frames, which the client cannot tell apart from a stuck warm-up.
  • Test: test_zero_warmup_timeout_env_reaches_bookmark_url checks that a 0 value survives env parsing and URL building, so it is not dropped as falsy.

No behavior change in Python; the env-var plumbing is already on main.

Test plan

🤖 Generated with Claude Code

…asses through

TELEOP_CLIENT_STREAM_ATTACH_TIMEOUT_MS, TELEOP_CLIENT_WARMUP_BEGIN_TIMEOUT_MS
and TELEOP_CLIENT_WARMUP_END_TIMEOUT_MS already reach the headset URL but were
missing from the OOB env var table. Document them, including that 0 disables
detection, and add a test that a 0 value survives env parsing and URL building.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: f98801a0-992e-4088-acf2-502c756140b5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch was successfully deployed

1 active deployment
dev — 9c92be11 Deployed Oct 13, 2026 by gareth-morgan-nv via publish-wheel #5574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants