Skip to content

docs: clarify camera view controls, stereo modes, and robot integration next steps - #1303

Merged
farbod-nv merged 2 commits into
mainfrom
fm/docs-camera-vdr
Oct 20, 2026
Merged

farbod-nv merged 2 commits into
mainfrom
fm/docs-camera-vdr

Conversation

@farbod-nv

@farbod-nv farbod-nv commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Clarifies the camera-streaming documentation to address remaining VDR documentation gaps:

  • States that controllers adjust the view without sending robot commands or recording demonstrations.
  • Explains ZED Mini UVC packed side-by-side video versus ZED SDK per-eye stereo.
  • Adds direct links to physical-robot and simulation teleoperation and recording guides.
    Validation: strict Sphinx documentation build and all applicable pre-commit checks passed.

Summary by CodeRabbit

  • Documentation
    • Clarified camera controller settings, including placement, shape, and stereo options.
    • Added guidance for ZED Mini packed UVC and per-eye ZED SDK stereo modes.
    • Clarified that the sample does not send robot commands or record demonstrations.
    • Added links to physical demonstration recording and simulated teleoperation guides.

Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: fbf39621-a9e8-461a-ac58-fce26a69e13d
📥 Commits

Reviewing files that changed from the base of the PR and between fda234b and 0b587d6.

📒 Files selected for processing: 1
  • docs/source/references/camera_streaming.rst

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Walkthrough

The camera streaming guide clarifies that controllers adjust camera views and that the sample does not send robot commands or record demonstrations. It describes how ZED Mini UVC and ZED SDK streams display stereo images. It also adds links to physical and simulated SO-101 teleoperation and demonstration-recording workflows.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 0b587

The documentation updates have no identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly and concisely summarizes the documentation changes to camera view controls, stereo modes, and robot integration links.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@farbod-nv farbod-nv changed the title Fm/docs camera vdr docs: clarify camera view controls, stereo modes, and robot integration next steps Oct 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Preview deployed: https://NVIDIA.github.io/IsaacCapture/preview/pr-1303/

Built from commit 0b587d6. It may take a minute for the updated preview to appear.

@ivany-nv ivany-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary
This adds a scope note to the camera-streaming guide (controllers change only the view; the sample neither commands a robot nor records), explains why a ZED Mini over UVC shows one packed side-by-side frame while zed.yaml gives per-eye stereo, and links the physical and simulated SO-101 recording guides from Next steps. Every claim matches the code at this head — build_local_camera rejects stereo for v4l2, zed.yaml ships stereo: true, and the sample never creates a TeleopSession or recorder — and CI, including the strict docs build, is green. No changes needed.

Legend: 🚫 BLOCKER = merge-blocking | 💡 SUGGESTION = meaningful improvement | 🧹 NIT = precise small correction

Finding
🚫 none
💡 none
🧹 none

@farbod-nv
farbod-nv merged commit 1a99e9d into main Oct 20, 2026
39 checks passed
@farbod-nv
farbod-nv deleted the fm/docs-camera-vdr branch October 20, 2026 23:35
github-actions Bot added a commit that referenced this pull request Oct 20, 2026
farbod-nv added a commit that referenced this pull request Oct 21, 2026
…on next steps (#1303) (#1306)

* docs: clarify camera viewing and robot integration next steps



* docs: remove unrequested agent guidance



---------


(cherry picked from commit 1a99e9d)

Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>

This branch was previously deployed

1 inactive deployment
dev — 0b587d6e Deployed Oct 20, 2026 by farbod-nv via publish-wheel #5782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants