fix: register adaptive plugin in doctor#186
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (5)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🧰 Additional context used📓 Path-based instructions (24){docs/**,README.md,CONTRIBUTING.md}📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Files:
{docs/**,README.md,CONTRIBUTING.md,**/*.md}📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Files:
{docs/**,README.md}📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Files:
{docs/**,examples/**,README.md}📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Files:
{docs/**,README.md,**/Cargo.toml,**/package.json,**/*.md}📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Files:
**/*.{md,mdx,py,sh,yaml,yml,toml,json}📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Files:
**/*.mdx📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Files:
**/*.{html,md,mdx}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
docs/**/*.{md,mdx}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
docs/**📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}⚙️ CodeRabbit configuration file
Files:
**/*.{md,rst,html,txt}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
Files:
**/*.{md,rst,html}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
Files:
**/*.md📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)
Files:
**/{docs,examples,**/*.md,*.patch,*.diff,.github,*.sh,*.yaml,*.yml}📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Files:
**/*.{md,rst,txt}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
Files:
**/*.{md,rst}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
Files:
**/README.md📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
**/*.rs📄 CodeRabbit inference engine (.agents/skills/add-binding-feature/SKILL.md)
Files:
{crates/adaptive/**/*.rs,**/*test*.{rs,py,go,ts,js},**/*adaptive*test*.{rs,py,go,ts,js},docs/plugins/adaptive/**}📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Files:
**/{Cargo.toml,**/*.rs}📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Files:
**/*.{h,hpp,c,cpp,rs}📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Files:
**/*.{rs,toml}📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Files:
{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (6)
WalkthroughThis PR integrates adaptive plugin registration into the doctor health-check pipeline and updates documentation to clarify Cursor support as experimental. The adaptive component now registers before downstream plugin validation, with early exit on registration failure. Documentation reflects that Cursor hook support is limited and cannot automatically route model traffic through the gateway. ChangesAdaptive Plugin Registration and Cursor Support
🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
|
Looked this over, good messaging around Cursor observability limitations in the docs in addition to the core aim |
|
/merge |
#### Overview Register the adaptive plugin component before `nemo-relay doctor` validates plugin configuration, and make Cursor support limitations more explicit in the CLI docs. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details - Register the built-in adaptive component before doctor plugin validation so adaptive plugin configs no longer report `plugin.unknown_component`. - Add a focused doctor regression test for adaptive validation. - Mark Cursor support as partial/highly experimental in the CLI overview. - Add prominent Cursor cautions for Fern and GitHub docs covering manual proxy/API-key setup, lack of automatic model routing, and subagent model behavior. Validation: - `cargo fmt --check` - `cargo test -p nemo-relay-cli collect_observability_registers_adaptive_before_validation -- --nocapture` - `just docs` - Commit pre-checks: docs linkcheck, `cargo fmt`, `cargo clippy`, and `cargo check` #### Where should the reviewer start? Start with `crates/cli/src/doctor.rs` for the adaptive registration path, then `docs/nemo-relay-cli/cursor.mdx` for the Cursor support warning. #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) - Relates to: none ## Summary by CodeRabbit * **Documentation** * Clarified Cursor integration support as highly experimental with limitations; cannot automatically route model traffic through the gateway * Updated observability support matrix for Cursor from fully supported to partial (highly experimental) * **New Features** * Enhanced doctor command to register adaptive components during observability health checks [](https://app.coderabbit.ai/change-stack/NVIDIA/NeMo-Relay/pull/186?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) Authors: - Will Killian (https://github.com/willkill07) Approvers: - Bryan Bednarski (https://github.com/bbednarski9) URL: NVIDIA#186 Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Overview
Register the adaptive plugin component before
nemo-relay doctorvalidates plugin configuration, and make Cursor support limitations more explicit in the CLI docs.Details
plugin.unknown_component.Validation:
cargo fmt --checkcargo test -p nemo-relay-cli collect_observability_registers_adaptive_before_validation -- --nocapturejust docscargo fmt,cargo clippy, andcargo checkWhere should the reviewer start?
Start with
crates/cli/src/doctor.rsfor the adaptive registration path, thendocs/nemo-relay-cli/cursor.mdxfor the Cursor support warning.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
Documentation
New Features