ci: use current docs helper for release snapshots#195
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🧰 Additional context used📓 Path-based instructions (3).github/workflows/*.{yml,yaml}📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md)
Files:
.{github/workflows/*.{yml,yaml},gitlab-ci.yml}📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Files:
{.github/**,.gitlab-ci.yml,.pre-commit-config.yaml,justfile,scripts/**}⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (1)📚 Learning: 2026-05-03T04:23:07.497ZApplied to files:
🔇 Additional comments (2)
WalkthroughThe ChangesWorkflow Tools Isolation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
#### Overview Fix manual Fern release snapshot reruns for historical tags. The release job should read documentation from the selected tag, but it must use the current workflow helper script so older tags can be repaired after workflow fixes land. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details - Add a separate `workflow-checkout` in `release-version-docs` for current workflow tooling. - Keep `source-checkout` pinned to the selected release tag so the docs content remains tag-sourced. - Invoke `sync_fern_docs_branch.py` from `workflow-checkout`, fixing manual reruns such as `tag=0.3.0` where the tag contains an older helper that does not support `--source-root`. Validation: - Reproduced the failing shape from https://github.com/NVIDIA/NeMo-Relay/actions/runs/26668928588/job/78608028705: source checkout from `0.3.0`, helper script from current branch, `release-version --source-root ... --tag 0.3.0`. - Verified the snapshot writes `fern/pages-v0.3.0` with the detailed release highlights. - `ruby -e 'require "yaml"; Dir[".github/workflows/*.{yml,yaml}"].each { |f| YAML.load_file(f) }; puts "yaml-ok"'` - `uv run pre-commit run --files .github/workflows/fern-docs.yml` - `uv run pre-commit run --all-files` #### Where should the reviewer start? Start with `.github/workflows/fern-docs.yml` in the `release-version-docs` job. The important detail is that workflow tools and release docs content now come from different checkouts. #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) - Relates to: https://github.com/NVIDIA/NeMo-Relay/actions/runs/26668928588/job/78608028705 ## Summary by CodeRabbit * **Chores** * Updated internal CI/CD workflow configuration for documentation synchronization processes. **Note:** This release contains no end-user visible changes. Updates are limited to workflow infrastructure improvements. [](https://app.coderabbit.ai/change-stack/NVIDIA/NeMo-Relay/pull/195?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) Signed-off-by: Will Killian <wkillian@nvidia.com> Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Overview
Fix manual Fern release snapshot reruns for historical tags. The release job should read documentation from the selected tag, but it must use the current workflow helper script so older tags can be repaired after workflow fixes land.
Details
workflow-checkoutinrelease-version-docsfor current workflow tooling.source-checkoutpinned to the selected release tag so the docs content remains tag-sourced.sync_fern_docs_branch.pyfromworkflow-checkout, fixing manual reruns such astag=0.3.0where the tag contains an older helper that does not support--source-root.Validation:
0.3.0, helper script from current branch,release-version --source-root ... --tag 0.3.0.fern/pages-v0.3.0with the detailed release highlights.ruby -e 'require "yaml"; Dir[".github/workflows/*.{yml,yaml}"].each { |f| YAML.load_file(f) }; puts "yaml-ok"'uv run pre-commit run --files .github/workflows/fern-docs.ymluv run pre-commit run --all-filesWhere should the reviewer start?
Start with
.github/workflows/fern-docs.ymlin therelease-version-docsjob. The important detail is that workflow tools and release docs content now come from different checkouts.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
Note: This release contains no end-user visible changes. Updates are limited to workflow infrastructure improvements.