Skip to content

fix(scripts): use TMPDIR-aware mktemp template in shell scripts#1546

Closed
mesutoezdil wants to merge 1 commit into
NVIDIA:mainfrom
mesutoezdil:fix/mktemp-tmpdir
Closed

fix(scripts): use TMPDIR-aware mktemp template in shell scripts#1546
mesutoezdil wants to merge 1 commit into
NVIDIA:mainfrom
mesutoezdil:fix/mktemp-tmpdir

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented May 23, 2026

Copy link
Copy Markdown
Contributor

Replaces bare mktemp calls with mktemp "${TMPDIR:-/tmp}/openshell-*.XXXXXX" in 2 scripts

Consistent with the pattern already used on line 227 of helm-k3s-local.sh

@copy-pr-bot

copy-pr-bot Bot commented May 23, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mesutoezdil

Copy link
Copy Markdown
Contributor Author

Closing -- this is a consistency improvement rather than a real bug, and there are already several PRs open for review.

@mesutoezdil mesutoezdil reopened this May 23, 2026
@github-actions

Copy link
Copy Markdown

Thank you for your interest in contributing to OpenShell, @mesutoezdil.

This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer.

To get vouched:

  1. Open a Vouch Request discussion.
  2. Describe what you want to change and why.
  3. Write in your own words — do not have an AI generate the request.
  4. A maintainer will comment /vouch if approved.
  5. Once vouched, open a new PR (preferred) or reopen this one after a few minutes.

See CONTRIBUTING.md for details.

@github-actions github-actions Bot closed this May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant