Skip to content

feat(router): warn when client-supplied model is rewritten #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
laitingsheng wants to merge 1 commit into from
Closed

feat(router): warn when client-supplied model is rewritten #1550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions crates/openshell-router/src/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ use crate::RouterError;
use crate::config::{AuthHeader, ResolvedRoute};
use crate::mock;
use std::collections::HashSet;
use tracing::warn;

#[derive(Debug, Clone, PartialEq, Eq)]
pub struct ValidatedEndpoint {
Expand Down Expand Up @@ -190,9 +191,22 @@ fn prepare_backend_request(

// Set the "model" field in the JSON body to the route's configured model so the
// backend receives the correct model ID regardless of what the client sent.
// When the caller supplied a non-empty model that differs from the configured
// route, emit a warning so the rewrite is visible to operators and silent
// model-typo / stale-reference bugs do not get masked by the rewrite.
let body = match serde_json::from_slice::<serde_json::Value>(&body) {
Ok(mut json) => {
if let Some(obj) = json.as_object_mut() {
if let Some(serde_json::Value::String(client_model)) = obj.get("model") {
if !client_model.is_empty() && client_model != &route.model {
warn!(
client_model = %client_model,
route_model = %route.model,
endpoint = %route.endpoint,
"router is rewriting client-supplied model to the configured route model",
);
}
}
obj.insert(
"model".to_string(),
serde_json::Value::String(route.model.clone()),
Expand Down
Loading