fix(openshell-network-supervisor): gate proxy accept on symlink resolution readiness#1968
Open
Cali0707 wants to merge 1 commit into
Open
fix(openshell-network-supervisor): gate proxy accept on symlink resolution readiness#1968Cali0707 wants to merge 1 commit into
Cali0707 wants to merge 1 commit into
Conversation
…ution readiness Signed-off-by: Calum Murray <cmurray@redhat.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The forward proxy accept loop can race with OPA engine's symlink resolution reload during sandbox startup. If a request is in-flight when the reload bumps the policy generation counter, the generation guard rejects it with a spurious 403. This is startup only: the initial engine is built with PID=0 (no symlink resolution), then a background task re-resolves with the real PID once
/proc/<pid>/rootis accessibly - two generation bumps for the same policy.This gates proxy
acceptbehind awatchchannel that fires once symlink resolution completes.Related Issue
Should resolve the e2e issues seen in #1891
Changes
tokio::sync::watchchannel that signals when symlink resolution finishes (success, failure, or skip)Testing
mise run pre-commitpassesChecklist