fix(snap): use snap-owned XDG directories#1972
Open
pimlock wants to merge 1 commit into
Open
Conversation
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Collaborator
Author
|
@zyga @drew This canary has been failing for a while now with the same error: https://github.com/NVIDIA/OpenShell/actions/workflows/release-canary.yml I'm not sure if fixing this was waiting on something, but couldn't find anything in flight, so got the most straightforward fix in here. Happy to close if there is anything else coming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Ubuntu Snap release canary failure where the snapped
openshellCLI tried to write gateway metadata under the host~/.config/openshelland hit snap confinement. The snap now points user-facing OpenShell commands at persistent snap-owned XDG directories under$SNAP_USER_COMMON.Related Issue
No existing issue found. Investigated failing Release Canary run: https://github.com/NVIDIA/OpenShell/actions/runs/27986564035
Changes
XDG_CONFIG_HOME,XDG_DATA_HOME, andXDG_STATE_HOMEfor theopenshellandtermsnap apps.Testing
uv run --frozen pytest python/openshell/release_formula_test.py -qmise run pre-commitpasses (skipped by request; the local workspace has unrelated untracked files that caused markdown/license checks to fail, and unrelated Rust check failures were also present)Checklist