fix(ci): fix linting issues#1985
Merged
Merged
Conversation
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
drew
approved these changes
Jun 24, 2026
Member
|
Another one for #1946? |
Collaborator
Author
Yes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the lint failures currently present at the tip of
main.Related Issue
N/A
Changes
openshell-serversoshutdown_tx.send(true)compiles.tokio::time::timeoutimport to Linux for the same reason.Findings
maincurrently failsmise run pre-commitbecause of two independent regressions.First bad commit for the sandbox lint failure:
48545cfb feat(sandbox): add GCE metadata emulator for Google Cloud (#1763)mise run rust:lintat48a7d09e, which passed, then at48545cfb, which failed.#[cfg(target_os = "linux")], so Linux clippy sees the modules as used. On macOS/non-Linux, the production caller is compiled out and-D warningsturns the modules/import into dead-code and unused-import errors.Second regression at the current
maintip:4ee27d99 feat(sandbox,providers): add aws-bedrock as a recognized inference provider (#1704)_shutdown_tx, butrun_serverstill callsshutdown_tx.send(true)later. The PR passed before merge because branch protection hasstrict: false; it was not rebuilt against the currentmainmerge result after4c75b854 fix(server): share gateway shutdown channel (#1945)changed the shutdown-channel shape.CI coverage that would have caught this before merge:
mise run rust:lintorcargo clippy --workspace --all-targets -- -D warnings.mainmerge result before merge.Testing
mise run rust:lintpassesmise run pre-commitpassesgit diff --checkpassesChecklist