fix: map Harbor trial folders to eval case ids - #104
Open
mimran-khan wants to merge 5 commits into
Open
Conversation
--refine keyed trajectories by the raw trial directory name, but Harbor writes folders like case-001__Lmi47iy. Split off the suffix so trajectories.get(case id) actually finds them. Fixes NVIDIA#93 Signed-off-by: mimran-khan <mohammed_imran.khan@outlook.com>
mimran-khan
requested review from
chrisknvidia,
mosheabr,
rmalani-nv and
rng1995
as code owners
August 26, 2026 20:15
rng1995
approved these changes
Aug 28, 2026
rng1995
left a comment
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the exact current head against #93 and the Harbor persisted-trial naming path. Suffixed folders map back to case ids and legacy unsuffixed folders remain unchanged. Focused tests pass (18), with Ruff and diff checks clean. No actionable findings; approved. The red Gitleaks job is unrelated branch history.
Collaborator
|
@mimran-khan - Please resolve merge conflicts |
Contributor
Author
|
Merged main in. Changelog conflict is resolved. |
# Conflicts: # CHANGELOG.md
Contributor
Author
|
Merged latest main (including #102) and resolved the CHANGELOG conflict. Ready for another look. |
Collaborator
|
Please resolve merge conflict in CHANGELOG.md so that I can merge it. Thanks for your contribution and patience @mimran-khan |
rng1995
enabled auto-merge (squash)
August 31, 2026 15:55
auto-merge was automatically disabled
August 31, 2026 17:06
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--refinekeyed trajectories by the raw Harbor trial folder name. Collection writescase-001__Lmi47iy, and eval cases arecase-001, so every lookup missed.Discovery now splits off the
__suffixand keys by the case id. A folder namedcase-001still works. Fixes #93.Verification
make lintmake testmake buildRelease Impact
CHANGELOG.md