Skip to content

fix(build_context): use forward-slash component paths (cross-platform) #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbhiramDwivedi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(build_context): use forward-slash component paths (cross-platform) #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/skillspector/nodes/build_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,10 @@ def _walk_skill_files(skill_dir: Path) -> list[str]:
continue
try:
rel = item.relative_to(skill_dir)
paths.append(str(rel))
# Use forward slashes on every OS: these relative paths are dict keys
# and SARIF/URI locations, so they must be portable (not OS-specific
# backslashes on Windows).
paths.append(rel.as_posix())
except ValueError:
logger.debug("Skipping path (not under skill_dir): %s", item)
continue
Expand Down
2 changes: 1 addition & 1 deletion tests/nodes/analyzers/test_semantic_developer_intent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ def _build_file_cache(skill_dir: Path) -> dict[str, str]:
for item in sorted(skill_dir.rglob("*")):
if not item.is_file():
continue
rel = str(item.relative_to(skill_dir))
rel = item.relative_to(skill_dir).as_posix() # forward slashes on every OS
try:
cache[rel] = item.read_text(encoding="utf-8", errors="replace")
except OSError:
Expand Down
2 changes: 1 addition & 1 deletion tests/nodes/analyzers/test_semantic_security_discovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ def _build_file_cache(skill_dir: Path) -> dict[str, str]:
for item in sorted(skill_dir.rglob("*")):
if not item.is_file():
continue
rel = str(item.relative_to(skill_dir))
rel = item.relative_to(skill_dir).as_posix() # forward slashes on every OS
try:
cache[rel] = item.read_text(encoding="utf-8", errors="replace")
except OSError:
Expand Down
2 changes: 1 addition & 1 deletion tests/nodes/test_semantic_quality_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ def _build_file_cache(skill_dir: Path) -> dict[str, str]:
for item in sorted(skill_dir.rglob("*")):
if not item.is_file():
continue
rel = str(item.relative_to(skill_dir))
rel = item.relative_to(skill_dir).as_posix() # forward slashes on every OS
try:
cache[rel] = item.read_text(encoding="utf-8", errors="replace")
except OSError:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_mcp_least_privilege.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def _make_state(fixture_name: str) -> dict:
continue
if item.name.startswith(".") and not item.name.startswith(".claude"):
continue
rel = str(item.relative_to(fixture_dir))
rel = item.relative_to(fixture_dir).as_posix() # forward slashes on every OS
components.append(rel)
components.sort()

Expand Down
2 changes: 1 addition & 1 deletion tests/test_mcp_tool_poisoning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def _make_state(
continue
if item.name.startswith(".") and not item.name.startswith(".claude"):
continue
rel = str(item.relative_to(fixture_dir))
rel = item.relative_to(fixture_dir).as_posix() # forward slashes on every OS
components.append(rel)
components.sort()

Expand Down