fix(labels): declare check labels only in suites#526
Open
mresvanis wants to merge 1 commit into
Open
Conversation
Per-check `labels:` wiring belongs in isvctl/configs/suites/*.yaml; the
nico provider configs redeclared control_plane/iam/network/min_req labels
in their standalone wiring, so `isvctl catalog labels --files` attributed
labels to provider files.
- Drop `labels:` from nico/config/{control-plane,iam,network}.yaml. Also
change nico's TenantInfoCheck test_id SDN01-02 to the "N/A" sentinel:
SDN01-02 is owned by VpcCrudCheck-read in suites/network.yaml, and the
provider-local attribution now trips the plan-coverage domain guardrail
(SDN implies label 'network', which TenantInfoCheck no longer carries).
- Document the rule in AGENTS.md so agents never reintroduce provider
labels. Exception: the single-node local providers
(k3s/microk8s/minikube.yaml), which wire host-level Bm* checks that
exist in no suite.
Accepted behavior change: `isvctl test run --provider nico --label <x>`
no longer discovers these standalone configs (they carry no labels and
import no suite); direct `-f <file>` runs are unaffected.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Michail Resvanis <mresvanis@nvidia.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-07-03 09:27:10 UTC | Commit: 106c643 |
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
labels:from the Nico provider configs (control-plane.yaml,iam.yaml,network.yaml) so labels are declared only inisvctl/configs/suites/*.yaml;isvctl catalog labels --filesnow attributes every label to suite files, with the single-node local providers (k3s/microk8s/minikube) as the only allowed exception.TenantInfoChecktest_idSDN01-02to the"N/A"sentinel:SDN01-02is owned byVpcCrudCheck-readinsuites/network.yaml, and the provider-local attribution trips the plan-coverage domain guardrail once thenetworklabel is gone.exclude.labels:filtering blocks remain fine).Accepted behavior change:
isvctl test run --provider nico --label <x>no longer discovers these standalone configs (they carry no labels and import no suite); direct-f <file>runs are unaffected.Test plan
uv run isvctl catalog labels --fileslists onlysuites/*.yaml(plus the exemptedproviders/{k3s,microk8s,minikube}.yaml) for every labelmake test(all packages + scripts)make demo-testuvx pre-commit run -a🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Bug Fixes