Skip to content

[STF] Refactor data_place to use polymorphic design #7976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andralex wants to merge 10 commits into
base: main
Choose a base branch
from
+927 −702
Open

[STF] Refactor data_place to use polymorphic design #7976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cfecafd
[STF] Refactor data_place to use polymorphic design
andralex Mar 10, 2026
4182e63
[pre-commit.ci] auto code formatting
pre-commit-ci[bot] Mar 10, 2026
2bc4771
[STF] Make data_place_interface::hash() pure virtual
andralex Mar 10, 2026
c01f7b3
[STF] Refine data_place_interface design
andralex Mar 10, 2026
d67f93f
[pre-commit.ci] auto code formatting
pre-commit-ci[bot] Mar 10, 2026
10c3877
Merge branch 'main' into stf_data_place_polymorphic
andralex Mar 10, 2026
4d74379
[STF] Fix Clang -Wordered-compare-function-pointers in data_place_com…
andralex Mar 10, 2026
536826a
[STF] Fix data_place_composite::cmp() and reduction plan memory node …
andralex Mar 10, 2026
70149e6
Merge branch 'main' into stf_data_place_polymorphic
andralex Mar 11, 2026
ede252b
[STF] Declare from_index at namespace scope for unqualified lookup
andralex Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cudax/include/cuda/experimental/__stf/internal/logical_data.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,8 +1467,7 @@ public:
continue;
}

// TODO THIS MAY BE A BUG: do we care about managed devices or host?
const auto memory_node = data_place::device(static_cast<int>(n - 2));
const auto memory_node = from_index(n);
// Skip the target memory node in this step
if (memory_node == target_memory_node)
{
Expand Down
217 changes: 0 additions & 217 deletions cudax/include/cuda/experimental/__stf/places/data_place_extension.cuh
View file
Open in desktop

This file was deleted.

Loading
Loading