Update libcudacxx header TU testing to reuse common cmake infra#7980
Open
jrhemstad wants to merge 1 commit intoNVIDIA:mainfrom
Open
Update libcudacxx header TU testing to reuse common cmake infra#7980jrhemstad wants to merge 1 commit intoNVIDIA:mainfrom
jrhemstad wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Contributor
miscco
reviewed
Mar 11, 2026
Comment on lines
+63
to
+64
| libcudacxx.test.public_headers_host_only.base | ||
| libcudacxx.test.public_headers_host_only |
Contributor
There was a problem hiding this comment.
What do we need those two for? Shouldnt libcudacxx.test.public_headers_host_only suffice?
Comment on lines
+84
to
+90
| string( | ||
| REGEX REPLACE | ||
| "([][+.*^$()|?\\\\])" | ||
| "\\\\\\1" | ||
| header_regex | ||
| "${header}" | ||
| ) |
Contributor
There was a problem hiding this comment.
I found the previous solution much much simpler
Comment on lines
+68
to
+77
| if ( | ||
| "MSVC" STREQUAL "${CMAKE_CXX_COMPILER_ID}" | ||
| AND | ||
| ( | ||
| "${header}" MATCHES "is_base_of" | ||
| OR "${header}" MATCHES "is_nothrow_destructible" | ||
| OR "${header}" MATCHES "is_polymorphic" | ||
| ) | ||
| ) | ||
| continue() |
Contributor
There was a problem hiding this comment.
Nitpick: This is pretty ugly compared to the previous code, can we keep the nested ifs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #7979
Updates the libcudacxx header testing to use the common
cccl_generate_header_testsmachinery.