Refactor _hf_download to improve subprocess handling and stdout capture#58
Closed
main-voice wants to merge 1 commit into
Closed
Refactor _hf_download to improve subprocess handling and stdout capture#58main-voice wants to merge 1 commit into
main-voice wants to merge 1 commit into
Conversation
main-voice
commented
Jun 25, 2026
main-voice
commented
Contributor
- Removed the --format=json option to allow tqdm progress bars to display correctly.
- Changed from subprocess.run to subprocess.Popen for better control over the child process.
- Captured stdout lines to ensure the last line (local snapshot path) is returned correctly.
- Added error handling to ensure the child process is killed on exceptions, preventing stale file-lock deadlocks.
- Removed the --format=json option to allow tqdm progress bars to display correctly. - Changed from subprocess.run to subprocess.Popen for better control over the child process. - Captured stdout lines to ensure the last line (local snapshot path) is returned correctly. - Added error handling to ensure the child process is killed on exceptions, preventing stale file-lock deadlocks.
foreverlms
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.