Skip to content

fix: bump example tokio pins past RUSTSEC-2026-0386 - #1619

Merged
roivanov merged 2 commits into
NVIDIA:mainfrom
roivanov:fix/example-tokio-advisory
Oct 23, 2026
Merged

roivanov merged 2 commits into
NVIDIA:mainfrom
roivanov:fix/example-tokio-advisory

Conversation

@roivanov

@roivanov roivanov commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes #1618. RUSTSEC-2026-0386 rejects tokio before 1.53.3 on the 1.53 line. These locks move to 1.54.1:

  • cuda-oxide/crates/rustc-codegen-cuda/examples/async_mlp
  • cuda-oxide/crates/rustc-codegen-cuda/examples/async_vecadd
  • cuda-oxide/crates/rustc-codegen-cuda/examples/cutile_inter_kernel
  • cutile-rs/Cargo.lock (cutile-rs/deny.toml checks advisories and does not ignore this one)
  • cutile-rs/cutile-benchmarks/paper/app_exp1_work_distribution/bimodal_gemms_rust

launch_overhead_rust still pins tokio 1.53.0. Its manifest patches dependencies to a local path outside this tree, so that lock was not updated here.

Test plan

  • cargo-deny / deny.toml governs the example workspaces passes
  • bash cuda-oxide/scripts/sync-example-locks.sh --check still reports one version per crate
  • cargo deny --manifest-path cutile-rs/Cargo.toml --locked check passes advisories

The example cargo-deny job rejects tokio 1.52.3. 1.54.1 is on the patched line.

Fixes NVIDIA#1618

Signed-off-by: Roman Ivanov <rivanov@nvidia.com>
@roivanov
roivanov requested a review from nihalpasham as a code owner October 23, 2026 16:35
@roivanov
roivanov requested review from cryos and elibol October 23, 2026 16:40
cutile-rs/deny.toml checks advisories and does not ignore this one.
tokio 1.52.1 is in the same vulnerable range as the example locks.

Signed-off-by: Roman Ivanov <rivanov@nvidia.com>
@roivanov roivanov added supply-chain Dependency policy: licenses, sources, security advisories, lock files examples Example kernels and host harnesses under crates/rustc-codegen-cuda/examples cutile-rs Tile programming model: cutile crates, compiler, macros, IR, kernels, and book labels Oct 23, 2026

@elibol elibol left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roivanov
roivanov merged commit fc74719 into NVIDIA:main Oct 23, 2026
68 checks passed
@roivanov
roivanov deleted the fix/example-tokio-advisory branch October 23, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cutile-rs Tile programming model: cutile crates, compiler, macros, IR, kernels, and book examples Example kernels and host harnesses under crates/rustc-codegen-cuda/examples supply-chain Dependency policy: licenses, sources, security advisories, lock files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cargo-deny: example locks pin tokio 1.52.3, rejected by RUSTSEC-2026-0386

2 participants