Repository navigation
Conversation
…igured-target test cargo_json_selects_custom_bin_in_configured_target_dir checks that the binary lands under build.target-dir from .cargo/config.toml. When the test process has CARGO_TARGET_DIR set (a common local and CI setting), Cargo uses that instead and the assertion fails. Remove the variable for the child build. Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commands::tests::cargo_json_selects_custom_bin_in_configured_target_dirchecks that the binary lands underbuild.target-dirfrom the fixture's.cargo/config.toml. If the test process hasCARGO_TARGET_DIRset, Cargo uses it instead, because the variable takes precedence over the config. The assertion then fails every time:just checkstops at this failure for anyone who setsCARGO_TARGET_DIR.Changes
CARGO_TARGET_DIRfrom the childcargo buildin that test.Testing
GH200 (aarch64),
CARGO_TARGET_DIRset:Checklist
git commit -s)