Skip to content

docs: fix moved thread indices in kernel examples - #1639

Open
0130w wants to merge 1 commit into
NVIDIA:mainfrom
0130w:fix/thread-idx-doc-examples
Open

0130w wants to merge 1 commit into
NVIDIA:mainfrom
0130w:fix/thread-idx-doc-examples

Conversation

@0130w

@0130w 0130w commented Oct 25, 2026

Copy link
Copy Markdown

Summary

Fix kernel examples in the cuda-oxide book that use a thread index after
passing it to DisjointSlice::get_mut. ThreadIndex is not Copy, so
these examples must save the numeric index before moving the witness.

Changes

  • Fix 11 examples across 7 book pages.
  • Read the numeric index before calling get_mut and use it for input
    slice access.

Testing

  • Sphinx HTML build with -W --keep-going: passed.
  • check-book-api-names.sh: passed.
  • check-book-import-order.sh: passed.
  • git diff --check: passed.

The full just check suite and GPU examples were not run; this change
only updates documentation. No new example was added.

Checklist

  • All commits signed off (git commit -s)
  • SPDX headers: not applicable; no new source files.

Questions about the review? Ping us in #contributors on Discord.

Signed-off-by: 0130w <1157374677@qq.com>
@0130w
0130w requested a review from nihalpasham as a code owner October 25, 2026 08:30
@copy-pr-bot

copy-pr-bot Bot commented Oct 25, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@0130w

0130w commented Oct 26, 2026

Copy link
Copy Markdown
Author

Hi @nihalpasham , it looks like CI is waiting for NVIDIA runner vetting. Could you help with the approval, or point me to the right person? Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant