Skip to content

[BUG] Makefile associated with NDS-H benchmark is not Mac Friendly #213

Description

@sayedbilalbari
  • Not idempotent. There needs to be a clean target.
  • () are not good practice in shell variable names (parens are used for execution), use {} to enclose variable names instead
  • sed with in place editing -i should include a backup file as best practice, and is required when running on a Mac
  • zsh on Mac does not interpolate $$ without escaping

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions